Plots2: Replace blog link with stories from Read Stories button

Created on 9 Mar 2018 · 13Comments · Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you :gift_heart:

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

:thinking: What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This will add _stories link_ to the Read Stories Button, currently the Read Stories Button is taking user to the blog page rather then the stories page. For reference I have provided the URL where the issue is and screen-shot below.

URL https://publiclab.org/home

screenshot from 2018-03-09 19-16-51

How to solve for new contributors

<p><a href="/blog" class="btn btn-primary btn-lg">Read stories »</a></p>

Just replace /blog with /wiki/stories from app/views/home/home.html.erb file in the codebase and this will fix the issue.

:clipboard: Step by Step

[ ] :raising_hand_woman: Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] :memo: Update the file app/views/home/home.html.erb in the plots2 repository so as to do the required changes.

See this page for some help in taking your first steps!

[ ] :floppy_disk: Commit your changes
[ ] :twisted_rightwards_arrows: Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] :checkered_flag: Done Ask in comments for a review :)

:thinking: :question: Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by @amitsin6h)

HTML fto-candidate

Source

amitsin6h

Most helpful comment

@seafr I was not aware about first-timers-bot thanks for your help. I have seen your comment , I have asked @mirzabob to make the changes.

amitsin6h on 13 Mar 2018

👍2

All 13 comments

Hey @amitsin6h , Can I work on this?

chitra591 on 9 Mar 2018

@mirzabob do you want to work ?? or I will assign it to @chitra591

amitsin6h on 9 Mar 2018

yeah i want to work on it.

On Fri, Mar 9, 2018 at 7:42 PM, Amit singh notifications@github.com wrote:

@mirzabob https://github.com/mirzabob do you want to work ?? or I will
assign it to @chitra591 https://github.com/chitra591

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2454#issuecomment-371822765,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AhhiuFSKu7PGT1cO0BN3bmJJYkIKFLEqks5tco3TgaJpZM4SkTm8
.

mirzabob on 9 Mar 2018

Hello @amitsin6h I worked it but it's giving a wrong tick again.

mirzabob on 9 Mar 2018

@mirzabob didn't get you

amitsin6h on 9 Mar 2018

@chitra591 I will create an another issue for you to work on, also visit https://publiclab.github.io/community-toolbox/#r=all

amitsin6h on 9 Mar 2018

screenshot from 2018-03-09 21-27-34
@amitsin6h This is the problem i am facing.

mirzabob on 9 Mar 2018

@mirzabob first close your PR which you made for the comment icon because your changes for this issue is reflecting in the first PR that you made.

I suggest you to remake PR for this issue. and also go through the git basics https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github also see the git work flow https://guides.github.com/introduction/flow/index.html.

and when you write you commit message also mention which issue the PR fixes.
For eg. Updated Read Stories button link (Fixes #issue-number)

amitsin6h on 9 Mar 2018

👍1

I just added a new one at #2458 !! @chitra591