Plots2: Minor changes for Social media icons on profile page

[grvsachdeva]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

Our Profile page needs some minor CSS fixes. Remove hover effects so that on hovering over social media icons, the black line doesn't generate.Instead, add the hover effect to enlarge social media icon on hover.And add the margin between each icon.

File that needs changes - https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb

Thank you!!

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/users/profile.html.erb in the plots2 repository so as to do the required changes.

See this page for some help in taking your first steps!

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[son-vyas]

I would like to give this a try. Thanks @Gauravano

[grvsachdeva]

That would be great !!!

[Paarmita]

@Gauravano Can I take up this issue?

[namangupta01]

@Paarmita Sure, Go ahead!

[Paarmita]

@Gauravano @namangupta01 Do I have to add social icons and then css? As icons are not shown

[grvsachdeva]

hi @Paarmita , you have to enter your facebook, twitter, etc username using Link social media button, and then icons would appear.

[Paarmita]

@Gauravano on clicking the Link social media button, it's not taking the username and accounts are not linking.

[grvsachdeva]

@Paarmita you have to follow the syntax as shown in the alert like if you want to add your facebook username on PublicLab then you need to add facebook:paarmita287 and similar syntax for twitter, instagram, and github.

[namanjain1812]

Can i take this issue?

[grvsachdeva]

Hi @namanjain1812 , we would love to have your help but this issue is under progress by @Paarmita . You can find new first -timer issues at https://publiclab.github.io/community-toolbox/#r=all and if you can't find one there please ping here I will create one for you.Thanks.

[grvsachdeva]

Update in the issue:

First, add class to the div at line https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb#L9 like this

-     <div style="text-align: center;">
+    <div class="profile_icons" style="text-align: center;">

and then append following CSS

  .profile_icons a{
    text-decoration: none;
  }

  i{
    margin-left: 8px;
  }

  i:hover{
    transition-duration: .2s;
    transform: scale(1.2);
  }

here https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb#L283-L287

[chanjess]

@Gauravano Hi Gauravano, open source newbie here. There aren't many first timer requests. Are there any upcoming ones I can help out on? Thanks!

[jywarren]

Hi! I've just added a new one here -- if you want to claim it? Welcome!!!

https://github.com/publiclab/plots2/issues/2695

On Sun, May 6, 2018 at 9:31 PM, chanjess [e-mail] wrote:

@Gauravano https://github.com/Gauravano Hi Gauravano, open source
newbie here. There aren't many first timer requests. Are there any upcoming
ones I can help out on? Thanks!

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2428#issuecomment-386933995,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ56gza841PTefLUzjlPJPTCQaELXks5tv6QOgaJpZM4Sa5tD
.

[CoderJolly]

anybody working on dis?

[grvsachdeva]

Hi @CoderJolly, this issue is solved. Sorry for inconvenience.