Plots2: Fix bad reference in node.rb

Created on 26 Feb 2018 · 10Comments · Source: publiclab/plots2

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

This issue is to fix a bad reference to node which should have been self -- to fix the display of http://publiclab.org/methods

📋 Step by Step

[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
[ ] 📝 Update the file app/models/node.rb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

@@ -723,7 +723,7 @@ def body_preview(length = 100)
   def questions
     # override with a tag like `questions:h2s`
     if self.has_power_tag('questions')
-      tagname = node.power_tag('questions')
+      tagname = self.power_tag('questions')
     else
       tagname = self.slug_from_path
     end

[ ] 💾 Commit your changes
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
You can also edit files directly in your browser and open a pull request from there.

[ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

first-timers-only has-pull-request help wanted

Source

first-timers[bot]

Most helpful comment

I opened the code and discovered this was already fixed! Checking the history, it appears to have been part of #2621. https://github.com/publiclab/plots2/pull/2621/files#diff-16d89387de9be2711872969affbc5b57L777

em1 on 3 Jun 2018

😄1 👍1

All 10 comments

@MittalS211 @amitsin6h if either of you are interested in this one, we'd be happy to help you out!

jywarren on 26 Feb 2018

I'll take it up!

On Mon 26 Feb, 2018, 9:59 PM Jeffrey Warren, notifications@github.com
wrote:

@MittalS211 https://github.com/mittals211 @amitsin6h
https://github.com/amitsin6h if either of you are interested in this
one, we'd be happy to help you out!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2398#issuecomment-368561208,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AglmCMzvT8ZWy9u6kO7z97cjs5riG9jzks5tYtv2gaJpZM4SThi1
.