Plots2: PLANNING ISSUE : Unpublished draft of research note for review by participants

[grvsachdeva]

Steps for implementation of the draft feature as suggested by @jywarren in #129 are :

• [x] making a draft status (maybe status = 3?) for nodes (not wiki pages), which makes it not visible to anyone but the author.
• [x] a POST parameter like draft=true to bypass most of the "create" method in the notes_controller and which adds the status = 3 when you publish
• [x] a button to post the form with the draft parameter set to true in the Rich Editor template
• [x] a modification of the with:____ coauthor tag (see this post which allows co-authors to see the post
• [ ] an alert at the top of a draft page that offers a shareable link to the post for sending around
• [ ] maybe a secret URL token that allows access to the post even if someone doesn't have an account?

[jywarren]

:-) this looks rad, thanks!!

[grvsachdeva]

Hi, @jywarren @ebarry @steviepubliclab due to adjacency in @ViditChitkara 's proposal and mine, we have decided to divide things as per @jywarren 's suggestions.So, starting with the 3rd part, UI for managing digest settings. Vidit would be doing this part. So, I am thinking to propose this issue i.e., Draft Creation but with some advanced features:-

1. UI for link sharing:-
   In this, modal would popup containing options to copy the secret link, there would be a column for entering Email Id or usernames to which that secret link would be mailed, inviting them to edit or give suggestions on the draft.

1. The comment section in the draft state would serve as discussion area so if any coauthor wants to give feedback they can write there.The discussion messages wouldn’t be visible publicly once the draft is published.

2. PDF creation of the research note

Please let me know if you find above parts interesting otherwise @ViditChitkara and I can divide the UI settings part. @publiclab/community-reps your ideas and feedback are welcome.Thanks.

[ViditChitkara]

@jywarren any thoughts on this?? I am happy to give the UI part a go. Could you please provide your feedback so that we could adjust our timelines accordingly?

[jywarren]

Yes, i'll write back today, sorry!!! 👍

[grvsachdeva]

@jywarren please give your views on these ideas https://github.com/publiclab/plots2/issues/2307#issuecomment-370518643 . Thanks.

[jywarren]

Sorry i said i'd write back but never did!

Let's try to make this simpler for starters -- we can offer the link to share without offering to mail it for you -- that'll simplify the initial implementation. It could even say I've shared a draft post from PublicLab.org with you -- click here to view and comment or edit: ________ -- you know?

The comment section in the draft state would serve as discussion area so if any coauthor wants to give feedback they can write there.

The discussion messages wouldn’t be visible publicly once the draft is published.

I'm not sure about this -- perhaps we can offer the author the ability to delete the comments one by one, in case -- but I worry that the "collaboration" ought to be public by default. If they don't want it to be, they can delete comments. Make sense? This simplifies our workflow here, and we can build it out more deeply in separate steps.

Thanks!!!

[grvsachdeva]

thanks, @jywarren .I will break the issue into smaller steps, and open a new Planning issue with some implementation details very soon.

[jywarren]

great!

On Mon, Mar 12, 2018 at 4:42 PM, Gaurav Sachdeva [e-mail]
wrote:

thanks, @jywarren https://github.com/jywarren .I will break the issue
into smaller steps, and open a new Planning issue with some implementation
details very soon.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2307#issuecomment-372455508,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0CQH8PkKuVbeyz5ayoSuG3_gXinks5tdt2tgaJpZM4SCaK4
.

[jywarren]

Hi! It looks like there may be a draft related bug here?

https://publiclab.org/notes/gauravano/03-13-2018/test-question

It fails on this line, with @node evaluating to nil --

https://github.com/publiclab/plots2/blob/8e9dec8787158cd504b68ba340557599c61434e4/app/controllers/notes_controller.rb#L55

Processing by NotesController#show as HTML
  Parameters: {"author"=>"gauravano", "date"=>"03-13-2018", "id"=>"test-question"}
Completed 500 Internal Server Error in 33ms (ActiveRecord: 28.2ms)

NoMethodError (undefined method `status' for nil:NilClass):
  app/controllers/notes_controller.rb:55:in `show'

Thanks!!!

[grvsachdeva]

actually @jywarren I deleted the node after testing it (probably after 4 minutes of its creation)

[grvsachdeva]

And, after deleting the node I tried the link too I guess that's how this log is generated

[jywarren]

OK! sounds great.

On Tue, Mar 13, 2018 at 1:45 PM, Gaurav Sachdeva [e-mail]
wrote:

actually @jywarren https://github.com/jywarren I deleted the node after
a minute of its creation

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2307#issuecomment-372756045,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ_lvqE5rGzhvIvTmNowNZbYfNamtks5teAW8gaJpZM4SCaK4
.

[jywarren]

Ooh, some of these are done now, huh?

[grvsachdeva]

yup :smiley: ! List updated.

[grvsachdeva]

Last two parts of checklist transferred to #2667 . I guess this one can be closed now @jywarren .Thanks.

[jywarren]

Awesome!