Plots2: Insert a "feature" block and tidy up JavaScript This change inserts a "feature" fixing #2110 but also cleans up the JavaScript formatting a bit. Relatively simple changes!

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/tag/index.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

This change inserts a "feature" fixing #2110 but also cleans up the JavaScript formatting a bit. Relatively simple changes!

See this page for some help in taking your first steps!

@@ -1,28 +1,26 @@
 <%= render :partial => "sidebar/featured" %>

 <div class="col-md-9">
-  <table style="width:100%">
-    <tr>
-     <th style="width: 50% ;">
-       <h1 style="font-family:Junction Light;"><%= t('tag.index.popular_tags') %></h1>
-     </th>
-   </tr>
- </table>
+
+  <h1 style="font-family:Junction Light;"><%= t('tag.index.popular_tags') %></h1>
+
+  <% cache('feature_tags-header', skip_digest: true) do %> 
+    <%= feature('tags-header') %> 
+  <% end %>
+
   <p><%= t('tag.index.browse_popular_tags') %></p>
-  <!-- Search Bar -->
-    <input class="form-control" type="text" id="myInput"  placeholder="Search for tags..">
-    <script>
-      $('#myInput').keypress(function (e) {
-           var key = e.which;
-           if(key == 13)  // the enter key code
-            {
-             var pre = document.getElementById("myInput").value ;
-
-              window.location.href = " <%= tags_path %>"+"/"+pre
-            }
-          });
-    </script>
-    <br><br>
+
+  <input class="form-control" type="text" id="myInput"  placeholder="Search for tags..">
+  <script>
+    $('#myInput').keypress(function (e) {
+      var key = e.which;
+      if (key == 13) { // enter key
+        var pre = document.getElementById("myInput").value;
+        window.location.href = "<%= tags_path %>"+"/" + pre
+      }
+    });
+  </script>
+  <br /><br />

   <table class="table">
     <tr>

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[mimilettd]

Hello! This is my first time contributing to open-source and I would love to take on this issue. I'll be in touch should I have any questions and if all goes well, will have a PR for you to review soon. Thanks!

[jywarren]

that's awesome and thank you! We're here to help if you need anything! 🎉👍🎈🦁

[jywarren]

Hi, @mimilettd how are you doing on this one? Need any help?

[MittalS211]

@jywarren seems like this issue hasn't been worked upon. May I take it up?

[MayankKashyap]

Yeah @MittalS211, I think you are right so you can take this one..

[MittalS211]

Hi, I have made the necessary changes in my local repository. I will submit the PR in a while, since I am not able to right now due to some error. I will contact you @MayankKashyap or @jywarren regarding it, if need be.

[MayankKashyap]

Okkay @MittalS211

[ebarry]

Exciting to see progress on this! Many people will really appreciate this!
I'm just mentioning this page so that -- as a next step, don't worry about it now -- we can align the design patterns with https://publiclab.org/methods as well, and plan ahead for how featured topics will eventually look on the front of publiclab.org. Aiming for coherence!

[jywarren]

Hi @MittalS211 or @mimilettd -- if either of you have started on this and you'd like to open a pull request, we'd be happy to help you out! Thanks!

[MittalS211]

Will try to get to this asap!

On Thu 8 Mar, 2018, 12:41 AM Jeffrey Warren, [e-mail]
wrote:

Hi @MittalS211 https://github.com/mittals211 or @mimilettd
https://github.com/mimilettd -- if either of you have started on this
and you'd like to open a pull request, we'd be happy to help you out!
Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2260#issuecomment-371250316,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AglmCK5vQwvgEUP6De_zpLunp_UXQShrks5tcDDsgaJpZM4R7gR0
.

[amitsin6h]

@MittalS211 let me know if you need help.

[jywarren]

Hi, @MittalS211 -- just checking -- did you open a PR for this, or need any support? Thanks a lot!!!

[namanjain1812]

hi,If no one is working on it currently i will like to work on it

[alator21]

I can work on it too.

[ViditChitkara]

Either one of you could work on this!!! We are happy to help. @mittalS211 , @mimilettd if you want to help on this, it would be great.
Thanks.

[alator21]

All i have to do is to apply the above changes to the specific file? @ViditChitkara

[ViditChitkara]

Yes @alator21. You can add your own changes too, if you feel they would be useful for this. Feel free to ping us if you have any doubts.

[alator21]

@ViditChitkara no i'm ok!