Plots2: Pagination broken at /research

[SidharthBansal]

The pagination is in accordance to the research section always. It does not change to the events section pagination on clicking on the events.

Eventhough we have only 3 events it showed us n pages because here n pages are required for r research notes.

[SidharthBansal]

Added to GCI dashboard

[aashna27]

It hasn't still been claimed by any student maybe because they are finding it hard. Should it be simplified ?

[SidharthBansal]

We would be happy if you can help

[oorjitchowdhary]

Hi.. where can I view the problem and also where is the code file ? Pls share it.. Thanks

[oorjitchowdhary]

This issue is still open right? I'd like to work on it

[SidharthBansal]

Go-ahead

On Tue, Nov 13, 2018, 3:07 PM Oorjit Chowdhary [e-mail]
wrote:

This issue is still open right? I'd like to work on it

—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2258#issuecomment-438199515,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ_IfBxMRXGGOqZ9NsCwxN2mLk2Vdks5uupK-gaJpZM4R7cSE
.

[oorjitchowdhary]

Hi.. where can I view the problem and also where is the code file ? Pls share it.. Thanks

@SidharthBansal

[SidharthBansal]

I am right now busy. Sorry. Someone from @publiclab/mentors will help.

On Tue, Nov 13, 2018, 3:15 PM Oorjit Chowdhary [e-mail]
wrote:

Hi.. where can I view the problem and also where is the code file ? Pls
share it.. Thanks

@SidharthBansal https://github.com/SidharthBansal

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2258#issuecomment-438202259,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ3egKI1bALXFW6tg-UBXDgbwMlz7ks5uupTOgaJpZM4R7cSE
.

[oorjitchowdhary]

@SidharthBansal Oh okay no prblem.. Really sorry to disturb you

[SidharthBansal]

No problem going for a viva. In exam hall. Hope you will understand

On Tue, Nov 13, 2018, 3:24 PM Oorjit Chowdhary [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal Oh okay no prblem..
Really sorry to disturb you

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2258#issuecomment-438205042,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ8oBDJ9-gtRnmo2Fw0Lpj1m3t7drks5uupbagaJpZM4R7cSE
.

[oorjitchowdhary]

Yes yes ... All the best 💯

[oorjitchowdhary]

Hi.. where can I view the problem and also where is the code file ? Pls share it.. Thanks

@publiclab/mentors where can I find it?

[jywarren]

Hi, I believe this ends up using this template: https://github.com/publiclab/plots2/blob/master/app/views/notes/_notes.html.erb

To display on this page: https://publiclab.org/research

I hope that helps! Can you upload a screenshot of the page as it is now? I would guess that Sidharth means when viewing just the questions. This might end up being a bit complicated...

[oorjitchowdhary]

This is the page as of now

[oorjitchowdhary]

Hi, I believe this ends up using this template: https://github.com/publiclab/plots2/blob/master/app/views/notes/_notes.html.erb

To display on this page: https://publiclab.org/research

I hope that helps! Can you upload a screenshot of the page as it is now? I would guess that Sidharth means when viewing just the questions. This might end up being a bit complicated...

I couldn't exactly get you

[oorjitchowdhary]

@SidharthBansal @jywarren Any idea... I really want to solve this

[oorjitchowdhary]

When opening publiclab.org/research, it redirects to publiclab.org/dashboard and the pagination here is correct

[kevinzluo]

@oorjitchowdhary
I believe what @SidharthBansal is referring to is the fact that if you only select some of the options from the dropdown, such as only events, the pagination is broken.

For example, once you select events, there are still 173 pages despite there being far fewer items. I think what is happening now is that all items that are not events are being removed while the events still stay on their same pages (like if you click page 173 there is an event from 8 years ago on it).

I think the tasks asks you to fix it so that it paginates correctly, with each page being filled with events.

Hope this helps.

[tsparksh]

@jywarren, can you check https://github.com/publiclab/plots2/issues/4026? I think it is indirectly related to this.

[okonek]

Hi, I am a GCI participant and have studied this task for very long. I have to filter the notes in the home controller, but I don't know by which index should I filter which type of note. How can I filter Questions, Events and Comments in the controller during the database query? What are the db indexes for every one of the type? Thanks.

[okonek]

Hi, I have resolved the issue in this PR: https://github.com/publiclab/plots2/pull/4042 Could you review please?

[SidharthBansal]

https://github.com/publiclab/plots2/issues/2258#issuecomment-439768310 correct.
Sorry for late replies. I was busy with my university work.