Plots2: Changes not saved when done using Inline rich wiki editor

[grvsachdeva]

Please describe the problem (or idea)

I have tried to change the text of https://publiclab.org/wiki/kits using the inline rich editor but changes are not saved.

What did you expect to see that you didn't?

What's your PublicLab.org username?

Gaurav

This can help us diagnose the issue:

Browser, version, and operating system

Ubuntu 17.04

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!

---

Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[Souravirus]

I want to work on this bug. So please assign this to me @Gauravano

[jywarren]

Hmm, did it still not work when you refreshed the page? Maybe there's a local caching issue?

[jywarren]

Note this may be part of https://github.com/publiclab/inline-markdown-editor/ -- but we're glad for your help, @Souravirus !!

[jywarren]

Oh, it looks like the submit button is reloading the page instead of sending a request via AJAX! That's not good.

[jywarren]

OK we've made progress on this but are now seeing a vid related bug in Sentry, linking the issue now...

[sentry-io[bot]]

Sentry issue: PLOTS2-2Y

[jywarren]

OK 2 thoughts - this could be related to the previous vid issue in https://github.com/publiclab/plots2/issues/5118 - we should look at whether the replace function is creating bad vids?

[jywarren]

Oh hmm, it's not the vid but some other duplicate key:

Mysql2::Error: Can't write; duplicate key in table 'node_revisions': INSERT INTO `node_revisions` (`nid`, `uid`, `title`, `body`, `teaser`, `log`, `timestamp`, `format`) VALUES (868, 524509, 'SoC ideas', 'This is the ideas page for...

[jywarren]

@gauravano, just adding code links to try to narrow this down:

Replace in the wiki controller:

https://github.com/publiclab/plots2/blob/cfb50b99f655ed5d991e987b0a0e2f96ea734b41/app/controllers/wiki_controller.rb#L361-L385

and test:

https://github.com/publiclab/plots2/blob/cfb50b99f655ed5d991e987b0a0e2f96ea734b41/test/functional/wiki_controller_test.rb#L441-L455

node.replace in node model (maybe likeliest place, given the new revision record:

https://github.com/publiclab/plots2/blob/cfb50b99f655ed5d991e987b0a0e2f96ea734b41/app/models/node.rb#L911-L920

And matching test:

https://github.com/publiclab/plots2/blob/cfb50b99f655ed5d991e987b0a0e2f96ea734b41/test/unit/node_test.rb#L314-L320

[jywarren]

I think it's running new_revision here:

https://github.com/publiclab/plots2/blob/cfb50b99f655ed5d991e987b0a0e2f96ea734b41/app/models/node.rb#L600-L606

but the vid should be auto-incrementing...

https://github.com/publiclab/plots2/blob/cfb50b99f655ed5d991e987b0a0e2f96ea734b41/app/models/revision.rb#L3

[ebarry]

I just tested the inline editor at https://publiclab.org/wiki/community-development?raw=true and when i clicked 'Save' button, the spinning wheel went on for over two minutes. When I got tired of waiting I reloaded the page, and the changes had not been saved.