Plots2: Fix "Show 0 more" on inline people lists

[SidharthBansal]

Please describe the problem (or idea)

Show 0 more is present in the people's list

What happened just before the problem occurred? Or what problem could this idea solve?
If there is no more stuff, the text should not appear

What did you expect to see that you didn't?

How to Solve:

You can check out @kevinzluo's work in https://github.com/publiclab/plots2/pull/3980 for solving this.

The file which would require changes will be https://github.com/publiclab/plots2/blob/master/app/views/grids/_people.html.erb

Please show us where to look

https://publiclab.org/w/power-tags#Inline+power+tags

[Ankit-Singla]

Hey, I would like to work on this.

[SidharthBansal]

I As the codes are overlapping in #2150 and #2151 so @Ankit-Singla is working on it

[JonathanXu1]

Hi, has this issue been fixed? I would like to work on it if it hasn't yet.

[kevinzluo]

@JonathanXu1 I was testing out this issue for #2150 (PR #3980 ) and it looks to be already fixed.

Here is a table with 10 items:

Here is a table w/ more than 10 items:

Just want to clarify that I was not the one who fixed the show 0 more; it was already fixed when I made my PR.

[grvsachdeva]

Hi @kevinzluo could you add a screenshot here showing the show more/less grid in action for people and add your PR number too(for reference). Thanks!

[SidharthBansal]

I don't think the issue is yet solved, please check https://publiclab.org/w/power-tags#Inline+power+tags

[JonathanXu1]

@kevinzluo I think you aren't experiencing the error because section does not include the <%= users.length - 10 %> attribute in the show more tag

[kevinzluo]

Thanks for the heads up. I didn't realize there were multiple partials for grids :smiley:. The ones i was using were the notes grids and never checked the people grids.

[SidharthBansal]

If anyone knows the solution and wants to send a patch then it will be great

[JonathanXu1]

@SidharthBansal I've sent a patch on #4253

[grvsachdeva]

@jazdao you wanna try this?

[vansjyo]

@SidharthBansal Can I try this if not yet solved?

[SidharthBansal]

Yeah sure Vanshika

On Thu, Mar 14, 2019, 9:28 AM Vanshika Gupta [e-mail]
wrote:

@SidharthBansal https://github.com/SidharthBansal Can I try this if not
yet solved?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2151#issuecomment-472695573,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AUACQ4wBoiqfVqPGChtrVTvwjBIQHx6jks5vWcjygaJpZM4RvnGh
.

[siaw23]

got for it! @vansjyo 😊🎉

[vansjyo]

We can replace the 9 with a 10 and I suppose the problem in this issue should be solved. What do you think?

https://github.com/publiclab/plots2/blob/7a0660a3fcbb40250394b68405299c41f894f7f9/app/views/grids/_people.html.erb#L21-L23

[vansjyo]

@SidharthBansal Is there anything more that you are expecting from this fix? If not, I'll open a PR, else please let me know. Thanks.

[grvsachdeva]

Yes @vansjyo, feel free to open a PR. Thanks!