Plots2: Update _form.html.erb to trigger reload of profile page after adding location tags

[first-timers[bot]]

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

• [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

• [ ] 📝 Update the file app/views/locations/_form.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below. See this page for some help in taking your first steps!

@@ -62,6 +62,7 @@
     if (blurredLocation.isBlurred()) tags = tags + ',' + 'location:blurred'
     if ($('#placenameDisplay').val() != 'Location unavailable') tags = tags + ',' + 'place:' + parameterize($('#placenameDisplay').val());
     addTag(tags);
+    <% if params[:reload] == "true" %>setTimeout(function() { location.reload(); }, 3000);<% end %>
   }

   function parameterize(input) {

• [ ] 💾 Commit your changes

• [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

2. You can also edit files directly in your browser and open a pull request from there.

• [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

[stlireri]

I'll be working on it.Thanks @jywarren

[jywarren]

Thanks!!!!!!

This'll require a change in this file too but I'm happy to help with that afterwards!

https://github.com/publiclab/plots2/blob/master/app/views/users/profile.html.erb#L166

[stlireri]

It'll be a pleasure working with you.

[jywarren]

:-) 👍

So, i was thinking about this and I think the original suggestion using params[:reload] should actually use just the variable name reload instead of params[:reload].

Then, I believe we should be able to add to the locals part of this line:

https://github.com/publiclab/plots2/blob/34935fb011a2982968c6a2e0b049eeb2aa791c78/app/views/users/profile.html.erb#L166

So, that line could say:

locals: { haslocation: false, reload: true }

That way this will trigger the reload on just the profile page, at least for now. How does that sound?

You can try this out yourself (as it currently works) by making an account at http://PublicLab.org, and going to your profile at http://PublicLab.org/profile.

Thanks again!

[mandymuf]

I could join if help is wanted!

[jywarren]

@stlireri how is it going here? any way I can help out?

@mandymuf if you'd like to help out perhaps check this list of issues: https://publiclab.github.io/community-toolbox/

We'd love your help but I think @stlireri is currently working on this one, thanks!

[sukhbir-singh]

Is this issue already solved up? otherwise I would like to work on this. Thank you.

[jywarren]

Hi, it sounds like @stlireri got busy with other things, perhaps -- @mandymuf or @sukhbir-singh please give it a try and chime in here. We'd love your help, but if you start, please open a PR soon so that others don't start on it also and then we have 2x the solution :-)

👍 Thanks all!

[sukhbir-singh]

@jywarren Is it correct that, In this issue we are trying to reload page [only profile page] when a location is added to user's profile for first time, or when user added a location tag when there is no already existing location set by user.

[jywarren]

It's any time a location is added, actually, which is probably the simplest. At some point we should have the form delete any existing locations too, but not for now. A good follow-up issue!

[jywarren]

Great work on the PR, @sukhbir-singh.

@stlireri if you're interested in taking on a new project, please ping me -- I'm very happy to help you or @mandymuf get started on something. Thanks for your interest!!!