Plots2: Adjust date of comments that are changed to answers on /questions

[steviepubliclab]

A new feature was added that allows people to move comments on /questions to answers. However, when comments are now adjusted, a new email goes out and the date of the original post is not maintained.

Here's a link to the code: https://github.com/publiclab/plots2/blob/ceb7d05404b4619c7fa8cd8cae5e8215798cb02c/app/controllers/comment_controller.rb#L154-L157

[jywarren]

Let's work on ensuring the dates are set to the original comment date first.

Then, we can suppress the emails by removing this line: https://github.com/publiclab/plots2/blob/ceb7d05404b4619c7fa8cd8cae5e8215798cb02c/app/controllers/comment_controller.rb#L161

Thanks, @steviepubliclab !!

[grvsachdeva]

Hi @steviepubliclab, I have implemented this feature so I am well familiar with the code.Can I help to resolve this? Thanks.

[jywarren]

@Gauravano yes please, that would be fantastic!!

[grvsachdeva]

Thanks, @jywarren .Actually @jywarren @steviepubliclab I have a suggestion regarding email like we have an email for a new answer, comment.etc. Can we make notification mail for this feature too?

[jywarren]

Hi, i think we already notify for new answers and comments, but we have
been interested in a "welcome email" feature for when people sign up for
the site initially. Would you wan to make a new issue for that and we can
try to draft what such an email should include?

Thanks, Gaurav!

On Sun, Feb 4, 2018 at 1:54 PM, Gaurav Sachdeva [e-mail]
wrote:

Thanks, @jywarren https://github.com/jywarren .Actually @jywarren
https://github.com/jywarren @steviepubliclab
https://github.com/steviepubliclab I have a suggestion regarding email
like we have an email for a new answer, comment.etc. Can we make
notification mail for this feature too?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2099#issuecomment-362930143,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ3Yro6EaYlONROlqrp-JG_TUnjjmks5tRfzmgaJpZM4Rr_kl
.

[grvsachdeva]

I am definitely interested in taking this one.Thanks, Jeff.

[jywarren]

awesome!!!

On Mon, Feb 5, 2018 at 4:00 PM, Gaurav Sachdeva [e-mail]
wrote:

I am definitely interested in taking this one.Thanks, Jeff.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/2099#issuecomment-363219689,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ5gScciRD6pq5v2UWhoOu9VV2gNlks5tR2vygaJpZM4Rr_kl
.