Plots2: Pictures in email subscription content are linked to error page

[ebarry]

What happened just before the problem occurred

I opened an email from do-not [email protected]. Emails like this are generated by subscriptions to content on publiclab.org. When i clicked on an image in the body of the email, it went to an error page.
This is a bug.

It would be OK if the picture was not clickable and simply didn't link to anything. But if it does link, then it should not be an error.

Relevant URLs

Actual content: https://publiclab.org/notes/partsandcrafts/10-26-2017/making-a-hackteria-microscope
Direct link to image: https://publiclab.org/system/images/photos/000/022/066/original/IMG_20171025_201244.jpg
Bad link that was attached to picture in email: https://www.google.com/url?hl=en&q=https:https://publiclab.org/system/images/photos/000/022/066/original/IMG_20171025_201244.jpg&source=gmail&ust=1509111591639000&usg=AFQjCNFT1bBUhz6tjIYVKSmn-P1t0_sjIQ

PublicLab.org username

liz

Browser, version, and operating system

using gmail in chrome on mac

For bug reports, fill out the above template; for feature requests, you can delete the template.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

[ViditChitkara]

@ebarry The problem might be due to an extra "https: " in the bad link.
I have tried removing the extra https and I get this:-

[jywarren]

Indeed -- the link starts with https:https: -- great catch, Vidit!

The template is wrong on this line:
https://github.com/publiclab/plots2/blob/master/app/views/subscription_mailer/notify_node_creation.html.erb#L13

I'll make a FTO issue for this!

On Thu, Oct 26, 2017 at 1:26 PM, Vidit [e-mail] wrote:

@ebarry https://github.com/ebarry The problem might be due to an extra
"https: " in the bad link.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/1730#issuecomment-339739137,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ2kTbnzAHoL7E956dm3regS_qSozks5swMDNgaJpZM4QHmbg
.

[jywarren]

This was just solved in #1737 -- thanks @ViditChitkara !

[ebarry]

Thanks @ViditChitkara! Great sleuthing.

On Friday, October 27, 2017, Jeffrey Warren [e-mail]
wrote:

This was just solved in #1737
https://github.com/publiclab/plots2/pull/1737 -- thanks @ViditChitkara
https://github.com/viditchitkara !

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/1730#issuecomment-340032190,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ2n7roiuj_-uuQ-bWDuWW5OVn-Pv4Jks5swhBzgaJpZM4QHmbg
.

--

[phone] / @lizbarry http://twitter.com/lizbarry / lizbarry.net

[ViditChitkara]

@ebarry , @jywarren thanks for your help.