Plots2: Make Bootstrap "Pop-over" area close when clicking outside

[StlMaris123]

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @jywarren to get it labelled. Or, if this is not your first time, try to solve it yourself!

---

Feature

When a user clicks on follow button to add a new tag, clicking outside the the pop up button shown above does not hide it. You have to re-click on the button for the pop up to disappear.

Relevant URLS

This is an example of a page where you can follow tags:
https://publiclab.org/wiki/openhour

FIX

Make the button responsive so that it hides the pop up contents on clicking outside it.

[jywarren]

Do you know how this might be done, or could you add a few more hints? It's a Bootstrap element: https://getbootstrap.com/

The "popover" code is actually on this line: https://github.com/publiclab/plots2/blob/master/app/views/like/_like.html.erb#L10

[StlMaris123]

I think it can be tackled used popover js function

[jywarren]

This is great -- i've marked it as help-wanted and if you'd like to upgrade it by adding the checklist and other helpful notes, we can make it a first-timers-only at some point.

[jywarren]

I did also change the title to try to make it a bit more descriptive to a newcomer, and added a section to the top mentioning how it could be "upgraded". Thanks!

[StlMaris123]

I also feel it cab be a nice first timer's issue.

On Tue, Jun 13, 2017 at 12:47 AM, Jeffrey Warren [e-mail]
wrote:

This is great -- i've marked it as help-wanted and if you'd like to
upgrade it by adding the checklist and other helpful notes, we can make it
a first-timers-only at some point.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/1457#issuecomment-307939645,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMdR2f1GUQftEFATXuGePLJjcJhcXl7zks5sDbH3gaJpZM4N1O74
.

[bassdeveloper]

Can I contribute?

[jywarren]

Yes please!

On Jun 25, 2017 12:28 PM, "Rishabh Chakrabarti" [e-mail]
wrote:

Can I contribute?

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/1457#issuecomment-310912794,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ22q8Y8HIbPBrSoiEEbaQXv3rP1Oks5sHorFgaJpZM4N1O74
.

[malachaifrazier]

Can this be closed now that the fix is merged?

[jywarren]

Oh, sorry! yes, closing now.

[jywarren]

Thanks!