Plots2: List of who pressed "like" should be shown on each answer in Q&A

[jywarren]

This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @jywarren to get it labelled.

---

Our new Q&A system is great, and people can "like" individual answers -- like one of the answers on this page:

https://publiclab.org/questions/gretchengehrke/09-20-2016/question-would-it-be-feasible-to-use-a-stationary-camera-to-conduct-emissions-opacity-evaluation

However, you can't tell who else liked the answer -- the way you can see who liked a question (or note):

This might take some UI design work -- maybe a caret menu like how it's implemented for questions:

https://github.com/publiclab/plots2/blob/master/app/views/like/_like.html.erb#L8-L14

[ryzokuken]

I'd love to work on this, as this issue was tagged help-wanted. However, I might run into some problems (being new to open source development) and might need help.

[ryzokuken]

https://github.com/publiclab/plots2/blob/master/app/views/answer_like/likes.js.erb

Renders the star based on if the answer is liked_by the current_user, I'd look into the liked_by function, maybe it has a list of people who have liked it already and all that's required is to display that list.

[jywarren]

We'd love your help and are happy to offer any assistance you might need.
Thanks a lot!

Just curious -- we're trying to improve our outreach to new contributors --
how did you happen to hear about us?

Thanks!

I think that's a good place to start!

On Tue, Sep 27, 2016 at 1:01 PM, Ujjwal Sharma [email protected]
wrote:

https://github.com/publiclab/plots2/blob/master/app/views/
answer_like/likes.js.erb

Renders the star based on if the answer is liked_by the current_user, I'd
look into the liked_by function, maybe it has a list of people who have
liked it already and all that's required is to display that list.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/843#issuecomment-249928791,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ6d7PN4LATHtQcOBoZ7-k3Sv2B1Mks5quUvZgaJpZM4KG92J
.

[ryzokuken]

@jywarren I got to you from up-for-grabs.net

It's great that you've been using the help-wanted tag to help newcomers get up to speed with this project.

[jywarren]

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

[jywarren]

Hi, just checking if you've gotten stuck on this at all, or if I could help in any way? Thanks!

[ryzokuken]

I'd get on this ASAP after the bower issue is closed. Thanks for reminding me :)

[Pk13055]

@ryzokuken Are you still tackling this?

[ryzokuken]

@Pk13055 No, please feel free to work on it. If you need any help, please feel free to ask here on Github or on our Github channel. Thanks.

[ananyo2012]

@Pk13055 Just checking in if you are working on this?

[Pk13055]

Yes, I will submit a PR within the day. I was actually caught up with
something else.

[ananyo2012]

Sure take your time.

[Pk13055]

@ryzokuken Can you link the function for liked_by_users? Can you also direct me to the code for the like button? I can get started on the pop-up menu for the same.

[ananyo2012]

Here is the code for answer like button https://github.com/publiclab/plots2/blob/master/app/views/questions/_answer.html.erb#L46
Here is the liked_by method https://github.com/publiclab/plots2/blob/master/app/models/concerns/node_shared.rb#L8-L10

[ryzokuken]

Thanks for the help, @ananyo2012

[Pk13055]

@ryzokuken I've made the required changes, I think it should be solved. However, my repo has some changes that haven't been pushed which I don't want to include in this PR; how should I proceed such that my feature-branch only contains this latest commit?

[ananyo2012]

@Pk13055 I hope you got through your problem?

[Pk13055]

@ananyo2012 Yes, the problem was a long time ago I hadn't properly created a branch and some commits always carried over to succeeding PRs; I created a new fork and (I hope) it shouldn't be a problem any longer.