Plots2: Garbled autoemail response to non-latin characters

[ebarry]

What happened just before the problem occurred

This research note was posted by a first time poster: https://publiclab.org/notes/Shizi/05-27-2016/kite-aerial-photography-in-china

• in my "subscription to all research notes" the characters were fine.
• in the email to moderators to approve or ban, the characters were fine.
• in the email saying a moderator had approved the post, the characters were fine.
• and then i got a 4th email in the thread addressed directly to me, and the characters were garbled:

¤7š®X³þšO¹¹bp¶›r‰í®&چ·Ÿ†Ûi³ÿé¹¹brV›¢¸?¦º ŠW¿J ³‰(bÎ/ÚŽë-¦‹-yÖ§{ Þ±æ«r èµç§¶+eyÖʊךz¸š–˜h¶ˆ+j˜rŠp¡Šv¿oúiEæ jwkzÊh Ûh¶ ©¢Ëaz·¡¶ÚlÿúnnXœ•¦è® ç¢×¬ý(bÎ/ôçnöÓ^¿’+^iêâjZa¢Ú ­ªaÊ)܆)Úþ˜ký«-ÊW

PublicLab.org username

@liz @shizi

Browser, version, and operating system

Chrome on OSX10.11.3

[jywarren]

Extra note: Liz is an admin, so the emails she was mentioning are
moderation emails. The final one is most likely the one sent to moderators
but that matches the "subscribe to all notes" email.
On May 27, 2016 9:48 AM, "Liz Barry" [email protected] wrote:

What happened just before the problem occurred

This research note was posted by a first time poster:
https://publiclab.org/notes/Shizi/05-27-2016/kite-aerial-photography-in-china

• in my "subscription to all research notes" the characters were fine.
• in the email to moderators to approve or ban, the characters were
  fine.
• in the email saying a moderator had approved the post, the
  characters were fine.
• and then i got a 4th email in the thread addressed directly to me,
  and the characters were garbled:
  ¤7š®X³þšO¹¹bp¶›r‰í®&چ·Ÿ†Ûi³ÿé¹¹brV›¢¸?¦º ŠW¿J ³‰(bÎ/ÚŽë-¦‹-yÖ§{ Þ±æ«r
  èµç§¶+eyÖʊךz¸š–˜h¶ˆ+j˜rŠp¡Šv¿oúiEæ jwkzÊh Ûh¶ ©¢Ëaz·¡¶ÚlÿúnnXœ•¦è®
  ç¢×¬ý(bÎ/ôçnöÓ^¿’+^iêâjZa¢Ú ­ªaÊ)܆)Úþ˜ký«-ÊW

PublicLab.org username

@liz https://github.com/liz @shizi https://github.com/shizi
Browser, version, and operating system

Chrome on OSX10.11.3

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/546, or mute the thread
https://github.com/notifications/unsubscribe/AABfJ6jzkb0bx2YlzBzzZFT03_otMzr5ks5qFvYtgaJpZM4IohKA
.

[posmatrach]

@jywarren @ebarry
I just received an email notification about being mentioned in this issue.

Please note that I am not in any way involved with this, and I certainly haven't posted anything on publiclab.org, especially not in Chinese, since not only that I am not Chinese, but I also don't speak the language (which is unfortunate, that would've been quite epic).

[jywarren]

Sorry, I think it was the result of one of the garbled characters triggering a notification. Please disregard and apologies!

Back to the code, though, the section which sends these various notifications (from our app) is here:

https://github.com/publiclab/plots2/blob/master/app/controllers/admin_controller.rb#L116
The mailer code is here: https://github.com/publiclab/plots2/blob/master/app/mailers/subscription_mailer.rb#L4

And the views themselves are here: https://github.com/publiclab/plots2/blob/master/app/views/subscription_mailer/notify_node_creation.html.erb

I also received garbled text, and am also an admin, but in the email I received, the entire body of the email was:

¤7š¯ «­éÿ¦“înXœ-¦Ü¢{k‰»­¢¶¡­ç

[jywarren]

I recommend pasting the Chinese characters into a test node fixture, and writing a test for them similar to: https://github.com/publiclab/plots2/blob/master/test/functional/admin_controller_test.rb#L247

Fixtures are here: https://github.com/publiclab/plots2/blob/master/test/fixtures/node.yml

[posmatrach]

@jywarren @ebarry

Actually, it's the section bellow that - PublicLab.org username - you can see @shizi.
GitHub interprets this as a mention (this is my GitHub username), while this is clearly intended as someone else's PublicLab username.

Apparently that person and I share a username, although not on the same platform. Please just refrain from writing PublicLab usernames with @ in GitHub, and everything will be fine.

Oh, and btw, had this been written in Python or Java, I would have been happy to help. Unfortunately Ruby is not my thing. :)

[ebarry]

haha sorry @shizi! i intended to indicate this person https://publiclab.org/profile/shizi Thanks for your good humored note.

[posmatrach]

@ebarry

No worries! Good luck with the issue and have a great weekend!

[ebarry]

Is it possible that this has been fixed? more recent postings have occurred in Chinese characters and i have not observed any garbled characters.

[grvsachdeva]

Can we close this @jywarren @ebarry as no such instances are reported? Thanks!

[ebarry]

I'm not sure that we've fully checked on non-latin characters, especially
Chinese characters which was the original issue. Is there a test we could
write for this?

On Mon, Mar 25, 2019, 12:06 PM Gaurav Sachdeva [e-mail]
wrote:

Can we close this @jywarren https://github.com/jywarren @ebarry
https://github.com/ebarry as no such instances are reported? Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/546#issuecomment-476265493,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAJ2n_pVFDPhe6AQeXjChZioz6HSHXK1ks5vaPPugaJpZM4IohKA
.

[jywarren]

I believe we should connect to https://github.com/publiclab/plots2/pull/4033
and https://github.com/publiclab/plots2/issues/3988 -- thank you!

On Mon, Mar 25, 2019 at 12:38 PM Liz Barry [e-mail] wrote:

I'm not sure that we've fully checked on non-latin characters, especially
Chinese characters which was the original issue. Is there a test we could
write for this?

On Mon, Mar 25, 2019, 12:06 PM Gaurav Sachdeva [e-mail]
wrote:

Can we close this @jywarren https://github.com/jywarren @ebarry
https://github.com/ebarry as no such instances are reported? Thanks!

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/546#issuecomment-476265493,
or mute the thread
<
https://github.com/notifications/unsubscribe-auth/AAJ2n_pVFDPhe6AQeXjChZioz6HSHXK1ks5vaPPugaJpZM4IohKA

.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/publiclab/plots2/issues/546#issuecomment-476279857,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AABfJ0LIJeWLEMtGaTAuGNetNHYfrOdcks5vaPtRgaJpZM4IohKA
.