Player: MovePicture does not disable Sine Effect set by ShowPicture

[carstene1ns]

This affects some games, for example _Rosy Despair_ (and likely the countdown in the _Super Smash Brothers_ clone)

The ShowPicture has Sine with strength 9 set, the first MovePicture has it disabled, the second sets it again:

To reproduce in Rosy Despair use --start-map-id 40 --new-game
Here is also a dedicated Testcase: issue1046.zip

| Player | RPG_RT |
| --- | --- |
| | |

[Ghabry]

Extended the test and filled the top row with combinations of zoom and rotate picture stuff.

issue1046.zip

[Ghabry]

I can't find my code anymore (maybe I deleted it because I failed). So this issue is free.

[Ghabry]

Found some initial code, maybe useful for someone https://gist.github.com/Ghabry/8ffb714aabd6eb0ad26d6732e5c89923

[scurest]

@Ghabry If you didn't get too far on this already, I'm working on #1063 so I'm already touching Game_Picture and can probably do this too.

[Ghabry]

@scurest
Great, you can do it if you want. I took 2 days ago another look at this and have a few more lines of code but 75% of my test cases still fail. So feel free to work on it :)

Here is the code: https://github.com/Ghabry/easyrpg-player/commit/a9373f8d774d0587f9890581ae310da9ca90186b

At least the "// Check if enough time left for another full rotation" code works as expected, the other things not really.

[carstene1ns]

Forgot to say that the Smash Bros countdown and the Rosy Despair signs are fixed. 👍