Player.js: IE11 'object doesn't support property or method 'isNaN''

Created on 6 Jun 2019  路  5Comments  路  Source: vimeo/player.js

Actual Behavior

There is the error in console for IE 11:

Doesn't work in IE11 - Object doesn't support property or method 'isNan'.

Steps to Reproduce

Just run video in IE11 (Document mode 11 (Default))

Analysis

This happens on IE11 with Document mode 11 (Default), but not on IE11 with Document mode Edge. Problem is not in this player.js, but in included one https://f.vimeocdn.com/p/3.11.27/js/player.js
Issue is caused by condition
(t=parseInt(t,10),Number.isNaN(t)) which is not IE11 friendly. This is only place where Number.isNaN is used.
There are 31 occurrences of isNan, so maybe this can be converted?

bug player

Most helpful comment

This should be resolved! Thanks for reporting.

All 5 comments

I can confirm that the current player.js isn't IE 11 compatible.

Here is a reproducible case:
https://codepen.io/rema/pen/xoboOm

Play the video, then stop it and try to play it again... I won't work. Other browsers work without a problem.

Note: You can't open Codepen on IE11, here is a debug mode link:
https://s.codepen.io/rema/debug/xoboOm/YvkgOnEdNQpk

Is this the correct place to report this error and check its status? The Help center is not very helpfull where to report this as it just sends me to the contact page (https://vimeo.com/help/contact). There is no option to ask/report developer/API related questions/issues.

Thank you all for bringing this to our attention. We are attempting to reproduce and then patch.

This should be resolved! Thanks for reporting.

@luwes @rebecca-sich Thank you for the quick response. Just to verify: the correct approach in reporting these kind of errors (not in this repo, but in the embed API of Vimeo that uses this repository) is this repository?

Was this page helpful?
0 / 5 - 0 ratings

Related issues

Peripona picture Peripona  路  8Comments

rassemdev picture rassemdev  路  7Comments

macliems picture macliems  路  7Comments

miloandco picture miloandco  路  3Comments

JohnnyWalkerDesign picture JohnnyWalkerDesign  路  4Comments