This is what addAll documentation says:
addAll: Replace current collection with provided collection
Then this really should be called replaceAll so people know their existing entities are being removed.
[x] Yes (Assistance is provided if you need help submitting a pull request)
[ ] No
@alex-okrushko
Yeah, we had a case where addAll was used by accident instead of addMany and that lead to hours of debugging 😵
Maybe alias replaceAll to addAll and depreciate it?
removeAll can also be renamed to clearAll, but it's less error-prone, I think.
I don't know, i like addAll 😢 . Or at least don't use replaceAll but setAll instead, makes it easier to write 👍
👍 for setAll if we're going to rename this.
@brandonroberts @MikeRyanDev any thoughts on this? It wasn't the first time 🕵️♀️
Sounds good to me. Let's introduce the new one, and deprecate the old one.
Most helpful comment
Sounds good to me. Let's introduce the new one, and deprecate the old one.