Platform: Docs: Missing "props" import on scoreboard-page.actions.ts example

Created on 8 Nov 2019  路  7Comments  路  Source: ngrx/platform

I think there is a missing import in the scoreboard-page.actions.ts example from the Reducers tutorial page (https://ngrx.io/guide/store/reducers)

I think the imports should change from:

import { createAction } from '@ngrx/store';
To this:
import { createAction, props } from '@ngrx/store';

Because the props method is used on the line
export const setScores = createAction('[Scoreboard Page] Set Scores', props<{game: Game}>());

Accepting PRs Docs Good First Issue community watch

All 7 comments

You're totally right @abinp !

Feel free to create a PR with the proposed change 馃憤

If @acb14js doesn't want to I can

Let's give @acb14js the time to answer @jordanpowell88

@timdeschryver just added the pull request

@acb14js I think you still have to create the pull request at https://github.com/ngrx/platform/pulls by clicking on "New pull request" (green button at the top right).

@timdeschryver Thanks for your patience, Its my first time creating a pull request. I think I've setup the pull request correctly now.

Super! Thanks @acb14js

Was this page helpful?
0 / 5 - 0 ratings

Related issues

NathanWalker picture NathanWalker  路  3Comments

hccampos picture hccampos  路  3Comments

ghost picture ghost  路  3Comments

dmytro-gokun picture dmytro-gokun  路  3Comments

bhaidar picture bhaidar  路  3Comments