Platform: DevTools: Test-View not visible

Created on 17 May 2019  路  12Comments  路  Source: ngrx/platform

Minimal reproduction of the bug/regression with instructions:

  1. Add StoreDevtoolsModule to your Module
      StoreDevtoolsModule.instrument({
         logOnly: true,
         // also tested with features: { test: true }
      }),
  1. Open DevTools in the Browser
  2. No Test-View available

Go to: https://ngrx-seed.stackblitz.io/ and open your DevTools and see that there is no Test-View visible

But, if you open the edit view of stackblitz (https://stackblitz.com/edit/ngrx-seed?file=src%2Fapp%2Fapp.module.ts) you can see that Stackblitz's own redux? does add the Test-View 馃槄

Expected behavior:

Have a Test-View like its visible on other sites.

Versions of NgRx, Angular, Node, affected browser(s) and operating system(s):

NGRX 7.4.0
Angular 7.2.13
Browsers: Chrome and Firefox

Other information:

I would be willing to submit a PR to fix this issue

[ ] Yes (Assistance is provided if you need help submitting a pull request)
[x] No

Accepting PRs Router Store community watch enhancement

Most helpful comment

Sorry for the delay, I traveled a lot lately and did not have time. I'll pick this up in the weekend and see what can be done.

All 12 comments

Cannot reproduce this. If I go to the StackBlitz example, the instance is visible in DevTools. Both router and counter properties are present.

DevTools Views

with NgRx Seed:
image

with Stackblitz itself:
image

As you see Trace and Test are missing

Yeah, there is something here. If I open dev tools and have a look they are there:

Screenshot 2019-05-17 at 20 34 34

However, if I refresh the page they dissapear. Closing and opening dev tools again will make them show up.

I don't get any on the NgRx Seed, using Vivaldi / Chrome on both Mac and Windows. 馃檨

Both browser have the latest version of the dev tools installed

Weird that you see this @adrianfaciu, it shouldn't show up AFAIK.

To have these features available we must identify ourselves as a redux app, see https://github.com/zalmoxisus/redux-devtools-extension/blob/master/npm-package/logOnly.js#L9 for ref.

For us, this would mean adding a type property at https://github.com/ngrx/platform/blob/55818268bac6048fbb972dacbf41c0bedd3da809/modules/store-devtools/src/extension.ts#L241

I tried it locally and the redux features become visible but sadly enough, will do nothing.

image

Hmm, that is weird.
If no one else is working on it, I can pick it up next and try to sort it out.

Yes, that's fine by me Adrian thanks!

About the "lib redux" issue, I ran into this problem as well, and it's basically a bug in the redux devtools https://github.com/zalmoxisus/remotedev-app/issues/40

@dummdidumm We can make it a redux app, https://github.com/ngrx/platform/issues/1868#issuecomment-493701654

But then you're getting some other problems 馃槀

Sorry for the delay, I traveled a lot lately and did not have time. I'll pick this up in the weekend and see what can be done.

ngrx race
A little update here, I just tried setting trace=true and type='redux' and got some traces. Not enough to see the origin but somewhat useful.

Edit: a Error.stackTraceLimit=100 fixed it

@alex-vg How did you activate Trace tab?

Was this page helpful?
0 / 5 - 0 ratings