Platform: Schematics: Add ng-add support with prompt for making our schematics default

Created on 31 Jan 2019  路  6Comments  路  Source: ngrx/platform

ng add @ngrx/schematics

Requirements:

  • [ ] Should prompt the user to set @ngrx/schematics as the default collection. If the user accepts, it should do the equivalent of https://ngrx.io/guide/schematics#default-schematics-collection
  • [ ] Docs
  • [ ] Tests
Schematics community watch enhancement

Most helpful comment

To avoid duplicate work, by working on this issue with multiple devs simultaneously, perhaps it would be better to assign someone to this issue?

All 6 comments

@brandonroberts if you'r accepting pr I can give it a try :)

Hey @brandonroberts, we're taking a look at this as well at Briebug. Curious how you test schematics in the repo outside of unit tests? Do you have any patterns for locally testing? I like to use a sandbox approach to develop and test with https://www.kevinschuchard.com/blog/2018-11-20-schematic-sandbox/

Thanks

I haven't used the sandbox approach but it seems nice!
I've used verdaccio in the past to host a private npm registry.

To avoid duplicate work, by working on this issue with multiple devs simultaneously, perhaps it would be better to assign someone to this issue?

I agree. @itayod claimed it first so I'm happy to step back or provided assistance if needed.

@schuchard its pretty manual right now. I've mostly used the nightly builds and test projects to validate, but something more automated such as sandboxing would be helpful. Its kinda meta, but I think a standalone library to do integration testing would be nice. This is similar to what you're doing already.

You use a clean CLI project
Run your schematic against it
Use the schematics CLI to read files from your CLI project and validate it was applied correctly.

It would at least help with potential breaking changes across major releases.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

doender picture doender  路  3Comments

dollyshah-02-zz picture dollyshah-02-zz  路  3Comments

oxiumio picture oxiumio  路  3Comments

axmad22 picture axmad22  路  3Comments

gperdomor picture gperdomor  路  3Comments