Planner: Black frame outside of the main ui

[ph0sph0rus15]

Describe the bug
The app has a black frame outside of the ui

To Reproduce
Open the app

Screenshots

Desktop (please complete the following information):

• OS or DE: OS: (k)ubuntu; DE: KDE
  OS: Ubuntu 19.10
  KDE: 5.16.5
  Qt: 5.12.4

[gokberkakdeniz]

it spams the following log:
(com.github.alainm23.planner:7584): Gtk-CRITICAL **: 14:13:46.580: _gtk_widget_get_preferred_size_for_size: assertion 'size >= -1' failed

system information
OS: Fedora 31
DE: XFCE 4.14
GTK2: 2.24.32
GTK3: 3.24.13
GTK4: 3.96.0

dnf package info
elementary-planner: 2.2.14-1.fc31
elementary-xfce-icon-theme: 0.14-1.fc31
elementary-icon-theme: 5.1.0-2.fc31
elementary-theme: 5.4.2-1.fc31

[ph0sph0rus15]

i confirm that "byte", the music player has the same problem

[gokberkakdeniz]

I found that the following css class in elementary theme causes the problem :

decoration {
    border-radius: 4px 4px 0 0;
    box-shadow:
        0 0 0 1px @decoration_border_color,
        0 14px 28px rgba(0, 0, 0, 0.35),
        0 10px 10px rgba(0, 0, 0, 0.22);
    margin: 12px;
}

Then, I set box-shadow to none and margin to 1px (to able to resize). Now, it is working.

window decoration {
    box-shadow: none;
    margin: 1px;
}

You can save this css snippet to ~/.config/gtk-3.0/gtk.css file to make it permanently.

[bfsgr]

Duplicate of #268

[alainm23]

@tncga Thanks a lot, that's a great solution, I'm trying it out now on elementary OS and Planner looks a little weird. I think we can add that style when Planner runs on another distribution.

Guys could confirm if this works for everyone?

[ph0sph0rus15]

It didnt work here but i think its because im using the flatpak version, what path should i use instead?

[alainm23]

I'm developing a patch right now. Can you please help me test it? I'll send you the instructions right now.

[ph0sph0rus15]

@alainm23 yeah, of course.

[alainm23]

Try it please:

git clone https://github.com/alainm23/planner.git
cd planner/build-aux/flatpak
flatpak-builder --install repo com.github.alainm23.planner.json --force-clean --user
flatpak run com.github.alainm23.planner

[ph0sph0rus15]

okay, going to try it now. Will give feedback

[ph0sph0rus15]

$ flatpak run com.github.alainm23.planner
error: app/com.github.alainm23.planner/x86_64/master not installed

I uninstalled the app before trying, should i install it again? does it works like a patch?

[alainm23]

No need to uninstall but if you did there is no problem.

[ph0sph0rus15]

i did uninstall it, am i missing some install command?

[alainm23]

Try it please:

git clone https://github.com/alainm23/planner.git
cd planner/build-aux/flatpak
flatpak-builder --install repo com.github.alainm23.planner.json --force-clean --user
flatpak run com.github.alainm23.planner

Yes, you have to follow the commands I sent you.

[ph0sph0rus15]

yes, i did it

[alainm23]

Great, now run Planner
flatpak run com.github.alainm23.planner

[ph0sph0rus15]

> $ flatpak run com.github.alainm23.planner
> error: app/com.github.alainm23.planner/x86_64/master not installed

[alainm23]

@zayn666
This is rare, when you run this command it gives you some error or message.
flatpak-builder --install repo com.github.alainm23.planner.json --force-clean --user

In my case Planner is installed correctly and gives me this message in the terminal.

[ph0sph0rus15]

yes it gave me some errors regarding the install of gnome sdk, installed it and now its io.elementary.BaseApp/x86_64/juno-19.08

[ph0sph0rus15]

installed it all, building now

[ph0sph0rus15]

okay so, runned it and the bug still remains

[alainm23]

@zayn666 I just uploaded an update, please rebuild the application and run it again.

flatpak-builder --install repo com.github.alainm23.planner.json --force-clean --user
flatpak run com.github.alainm23.planner

[ph0sph0rus15]

okay, building

[ph0sph0rus15]

Working great! Confirming that it works

[ph0sph0rus15]

okay so, i assume the update is being pushed, how should i clean it? I dont really work with flatpak that much

[ph0sph0rus15]

i removed the package as normal.