Pkp-lib: Clean code for PHP 7

[crism]

Summary of PRs: https://github.com/pkp/pkp-lib/issues/3578#issuecomment-404679076

ojs

• [x] PHP Warning: Declaration of SubmissionFileDAO::fromRow($row) should be compatible with PKPSubmissionFileDAO::fromRow($row, $fileImplementation) in classes/article/SubmissionFileDAO.inc.php on line 23
• [x] PHP Warning: Declaration of & UserSettingsDAO::getSetting($userId, $name, $journalId = NULL) should be compatible with & PKPUserSettingsDAO::getSetting($userId, $name, $assocType = NULL, $assocId = NULL) in classes/user/UserSettingsDAO.inc.php on line 19
• [x] PHP Warning: Declaration of & UserSettingsDAO::getUsersBySetting($name, $value, $type = NULL, $journalId = NULL) should be compatible with & PKPUserSettingsDAO::getUsersBySetting($name, $value, $type = NULL, $assocType = NULL, $assocId = NULL) in classes/user/UserSettingsDAO.inc.php on line 19
• [x] PHP Warning: Declaration of UserSettingsDAO::deleteSetting($userId, $name, $journalId = NULL) should be compatible with PKPUserSettingsDAO::deleteSetting($userId, $name, $assocType = NULL, $assocId = NULL) in classes/user/UserSettingsDAO.inc.php on line 19
• [x] PHP Warning: Declaration of UserSettingsDAO::updateSetting($userId, $name, $value, $type = NULL, $journalId = NULL) should be compatible with PKPUserSettingsDAO::updateSetting($userId, $name, $value, $type = NULL, $assocType = NULL, $assocId = NULL) in classes/user/UserSettingsDAO.inc.php on line 19
• [x] PHP Warning: Declaration of IssueGridRow::initialize($request) should be compatible with GridRow::initialize($request, $template = NULL) in controllers/grid/issues/IssueGridRow.inc.php on line 0
• [x] PHP Warning: Declaration of SettingsPluginGridHandler::loadCategoryData($request, $categoryDataElement, $filter) should be compatible with PluginGridHandler::loadCategoryData($request, &$categoryDataElement, $filter) in controllers/grid/settings/plugins/SettingsPluginGridHandler.inc.php on line 18
• [x] PHP Warning: Declaration of SectionForm::execute($args, $request) should be compatible with Form::execute() in controllers/grid/settings/sections/form/SectionForm.inc.php on line 18
• [x] PHP Warning: Declaration of SectionForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in controllers/grid/settings/sections/form/SectionForm.inc.php on line 18
• [x] PHP Warning: Declaration of SectionForm::initData($args, $request) should be compatible with Form::initData() in controllers/grid/settings/sections/form/SectionForm.inc.php on line 18
• [x] PHP Warning: Declaration of MastheadForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in controllers/tab/settings/masthead/form/MastheadForm.inc.php on line 18

• [x] PHP Warning: Declaration of MastheadForm::initData($request) should be compatible with ContextSettingsForm::initData() in controllers/tab/settings/masthead/form/MastheadForm.inc.php on line 18

  omp

• [x] audit Form::display()

• [x] audit Form::execute()
• [x] audit Form::fetch()
• [x] sanify uses of getRequest()
• [x] audit Form::initData()
• [x] check out UserSettingsDAO
• [x] omp: Unknown locale component 263, referer: .../omp_dev/pww_test/submissions
• [x] PHP Warning: Declaration of SubmissionFileDAO::fromRow($row) should be compatible with PKPSubmissionFileDAO::fromRow($row, $fileImplementation) in classes/monograph/SubmissionFileDAO.inc.php on line 23
• [x] PHP Warning: Declaration of CategoryCategoryGridHandler::getDataElementInCategorySequence($categoryId, $category) should be compatible with CategoryGridHandler::getDataElementInCategorySequence($categoryId, &$gridDataElement) in controllers/grid/settings/category/CategoryCategoryGridHandler.inc.php on line 26
• [x] PHP Warning: Declaration of CategoryCategoryGridHandler::initialize($request) should be compatible with CategoryGridHandler::initialize($request, $args = NULL) in controllers/grid/settings/category/CategoryCategoryGridHandler.inc.php on line 26
• [x] PHP Warning: Declaration of CategoryCategoryGridHandler::loadCategoryData($request, &$category, $filter) should be compatible with CategoryGridHandler::loadCategoryData($request, &$categoryDataElement, $filter = NULL) in controllers/grid/settings/category/CategoryCategoryGridHandler.inc.php on line 26
• [x] PHP Warning: Declaration of CategoryCategoryGridHandler::setDataElementInCategorySequence($parentCategoryId, $category, $newSequence) should be compatible with CategoryGridHandler::setDataElementInCategorySequence($categoryId, &$gridDataElement, $newSequence) in controllers/grid/settings/category/CategoryCategoryGridHandler.inc.php on line 26
• [x] PHP Warning: Declaration of CategoryGridCategoryRow::initialize($request) should be compatible with GridRow::initialize($request, $template = NULL) in controllers/grid/settings/category/CategoryGridCategoryRow.inc.php on line 0
• [x] PHP Warning: Declaration of SettingsPluginGridHandler::loadCategoryData($request, $categoryDataElement, $filter) should be compatible with PluginGridHandler::loadCategoryData($request, &$categoryDataElement, $filter = NULL) in controllers/grid/settings/plugins/SettingsPluginGridHandler.inc.php on line 18
• [x] PHP Warning: Declaration of SeriesGridHandler::initialize($request) should be compatible with SetupGridHandler::initialize($request, $args = NULL) in controllers/grid/settings/series/SeriesGridHandler.inc.php on line 19
• [x] PHP Warning: Declaration of SeriesForm::validate() should be compatible with Form::validate($callHooks = true) in controllers/grid/settings/series/form/SeriesForm.inc.php on line 19

• [x] PHP Warning: Declaration of ManageCatalogHandler::initialize($request, $args) should be compatible with PKPHandler::initialize($request) in pages/manageCatalog/ManageCatalogHandler.inc.php on line 0

  pkp-lib

• [x] PHP Warning: Declaration of PKPSiteSettingsForm::display() should be compatible with Form::display($request = NULL, $template = NULL) in lib/pkp/classes/admin/form/PKPSiteSettingsForm.inc.php on line 23

• [x] PHP Warning: Declaration of PKPSiteSettingsForm::execute($request) should be compatible with Form::execute() in lib/pkp/classes/admin/form/PKPSiteSettingsForm.inc.php on line 23
• [x] PHP Warning: Declaration of CategoryGridHandler::doSpecificFetchGridActions($args, $request, &$templateMgr) should be compatible with GridHandler::doSpecificFetchGridActions($args, $request, $templateMgr) in lib/pkp/classes/controllers/grid/CategoryGridHandler.inc.php on line 0
• [x] PHP Warning: Declaration of PluginGridHandler::initialize($request) should be compatible with CategoryGridHandler::initialize($request, $args = NULL) in lib/pkp/classes/controllers/grid/plugins/PluginGridHandler.inc.php on line 20
• [x] PHP Warning: Declaration of PluginGridHandler::loadCategoryData($request, &$categoryDataElement, $filter) should be compatible with CategoryGridHandler::loadCategoryData($request, &$categoryDataElement, $filter = NULL) in lib/pkp/classes/controllers/grid/plugins/PluginGridHandler.inc.php on line 20
• [x] PHP Warning: Declaration of ContextSettingsForm::execute($request) should be compatible with Form::execute() in lib/pkp/classes/controllers/tab/settings/form/ContextSettingsForm.inc.php on line 20
• [x] PHP Warning: Declaration of ContextSettingsForm::fetch($request, $params = NULL) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/controllers/tab/settings/form/ContextSettingsForm.inc.php on line 20
• [x] PHP Warning: Declaration of ContextSettingsForm::initData($request) should be compatible with Form::initData() in lib/pkp/classes/controllers/tab/settings/form/ContextSettingsForm.inc.php on line 20
• [x] PHP Warning: Declaration of ContextSettingsForm::readInputData($request) should be compatible with Form::readInputData() in lib/pkp/classes/controllers/tab/settings/form/ContextSettingsForm.inc.php on line 20
• [x] PHP Warning: Parameter 1 to CategoryGridHandler::fetchCategory() expected to be a reference, value given in lib/pkp/classes/core/PKPRouter.inc.php on line 372
• [x] PHP Warning: Declaration of TemporaryFileManager::deleteFile($fileId, $userId) should be compatible with FileManager::deleteFile($filePath) in lib/pkp/classes/file/TemporaryFileManager.inc.php on line 19
• [x] PHP Warning: Declaration of TemporaryFileManager::downloadFile($fileId, $userId, $inline = false) should be compatible with FileManager::downloadFile($filePath, $mediaType = NULL, $inline = false, $fileName = NULL) in lib/pkp/classes/file/TemporaryFileManager.inc.php on line 19
• [x] PHP Warning: Declaration of PKPNotificationSettingsForm::execute($request) should be compatible with Form::execute() in lib/pkp/classes/notification/form/PKPNotificationSettingsForm.inc.php on line 22
• [x] PHP Warning: Declaration of PKPNotificationSettingsForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/notification/form/PKPNotificationSettingsForm.inc.php on line 22
• [x] PHP Notice: Undefined index: count in lib/pkp/classes/services/UserService.inc.php on line 54
• [x] PHP Warning: Declaration of APIProfileForm::execute($request) should be compatible with BaseProfileForm::execute($request, $user) in lib/pkp/classes/user/form/APIProfileForm.inc.php on line 20
• [x] PHP Warning: Declaration of APIProfileForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/user/form/APIProfileForm.inc.php on line 20
• [x] PHP Warning: Declaration of BaseProfileForm::execute($request, $user) should be compatible with Form::execute() in lib/pkp/classes/user/form/BaseProfileForm.inc.php on line 18
• [x] PHP Warning: Declaration of ChangePasswordForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/user/form/ChangePasswordForm.inc.php on line 19
• [x] PHP Warning: Declaration of ContactForm::execute($request) should be compatible with BaseProfileForm::execute($request, $user) in lib/pkp/classes/user/form/ContactForm.inc.php on line 18
• [x] PHP Warning: Declaration of ContactForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/user/form/ContactForm.inc.php on line 18
• [x] PHP Warning: Declaration of IdentityForm::execute($request) should be compatible with BaseProfileForm::execute($request, $user) in lib/pkp/classes/user/form/IdentityForm.inc.php on line 18
• [x] PHP Warning: Declaration of IdentityForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/user/form/IdentityForm.inc.php on line 18
• [x] PHP Warning: Declaration of PublicProfileForm::execute($request) should be compatible with BaseProfileForm::execute($request, $user) in lib/pkp/classes/user/form/PublicProfileForm.inc.php on line 22
• [x] PHP Warning: Declaration of PublicProfileForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/user/form/PublicProfileForm.inc.php on line 22
• [x] PHP Warning: Declaration of RolesForm::execute($request) should be compatible with BaseProfileForm::execute($request, $user) in lib/pkp/classes/user/form/RolesForm.inc.php on line 18
• [x] PHP Warning: Declaration of RolesForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/classes/user/form/RolesForm.inc.php on line 18
• [x] PHP Warning: Declaration of ContextGridHandler::loadData($request) should be compatible with GridHandler::loadData($request, $filter) in lib/pkp/controllers/grid/admin/context/ContextGridHandler.inc.php on line 0
• [x] PHP Warning: Declaration of ContextSiteSettingsForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/admin/context/form/ContextSiteSettingsForm.inc.php on line 19
• [x] PHP Warning: Declaration of AdminLanguageGridHandler::initialize($request) should be compatible with LanguageGridHandler::initialize($request, $args = NULL) in lib/pkp/controllers/grid/admin/languages/AdminLanguageGridHandler.inc.php on line 22
• [x] PHP Warning: Declaration of ManageAnnouncementGridHandler::authorize($request, &$args, $roleAssignments) should be compatible with AnnouncementGridHandler::authorize($request, &$args, $roleAssignments, $requireAnnouncementsEnabled = true) in lib/pkp/controllers/grid/announcements/ManageAnnouncementGridHandler.inc.php on line 20
• [x] PHP Warning: Declaration of ManageAnnouncementGridHandler::initialize($request) should be compatible with AnnouncementGridHandler::initialize($request, $args = NULL) in lib/pkp/controllers/grid/announcements/ManageAnnouncementGridHandler.inc.php on line 20
• [x] PHP Warning: Declaration of AnnouncementForm::execute($request) should be compatible with Form::execute() in lib/pkp/controllers/grid/announcements/form/AnnouncementForm.inc.php on line 19
• [x] PHP Warning: Declaration of AnnouncementForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/announcements/form/AnnouncementForm.inc.php on line 19
• [x] PHP Warning: Declaration of AnnouncementTypeForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/announcements/form/AnnouncementTypeForm.inc.php on line 20
• [x] PHP Warning: Declaration of LibraryFileGridCategoryRow::initialize($request) should be compatible with GridRow::initialize($request, $template = NULL) in lib/pkp/controllers/grid/files/LibraryFileGridCategoryRow.inc.php on line 0
• [x] PHP Warning: Declaration of LibraryFileGridHandler::initialize($request) should be compatible with CategoryGridHandler::initialize($request, $args = NULL) in lib/pkp/controllers/grid/files/LibraryFileGridHandler.inc.php on line 25
• [x] PHP Warning: Declaration of InstallLanguageForm::execute($request) should be compatible with Form::execute() in lib/pkp/controllers/grid/languages/form/InstallLanguageForm.inc.php on line 19
• [x] PHP Warning: Declaration of InstallLanguageForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/languages/form/InstallLanguageForm.inc.php on line 19
• [x] PHP Warning: Declaration of InstallLanguageForm::initData($request) should be compatible with Form::initData() in lib/pkp/controllers/grid/languages/form/InstallLanguageForm.inc.php on line 19
• [x] PHP Warning: Declaration of InstallLanguageForm::readInputData($request) should be compatible with Form::readInputData() in lib/pkp/controllers/grid/languages/form/InstallLanguageForm.inc.php on line 19
• [x] PHP Warning: Declaration of LanguageGridCellProvider::getCellActions($request, $row, $column) should be compatible with GridCellProvider::getCellActions($request, $row, $column, $position = GRID_ACTION_POSITION_DEFAULT) in lib/pkp/controllers/grid/languages/LanguageGridCellProvider.inc.php on line 0
• [x] PHP Warning: Declaration of NavigationMenuForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/navigationMenus/form/NavigationMenuForm.inc.php on line 20
• [x] PHP Warning: Declaration of NavigationMenuForm::validate() should be compatible with Form::validate($callHooks = true) in lib/pkp/controllers/grid/navigationMenus/form/NavigationMenuForm.inc.php on line 20
• [x] PHP Warning: Declaration of NavigationMenuItemsForm::execute($request) should be compatible with Form::execute() in lib/pkp/controllers/grid/navigationMenus/form/NavigationMenuItemsForm.inc.php on line 19
• [x] PHP Warning: Declaration of NavigationMenuItemsForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/navigationMenus/form/NavigationMenuItemsForm.inc.php on line 19
• [x] PHP Warning: Declaration of NavigationMenuItemsForm::validate() should be compatible with Form::validate($callHooks = true) in lib/pkp/controllers/grid/navigationMenus/form/NavigationMenuItemsForm.inc.php on line 19
• [x] PHP Warning: Declaration of UploadPluginForm::execute($request) should be compatible with Form::execute() in lib/pkp/controllers/grid/plugins/form/UploadPluginForm.inc.php on line 22
• [x] PHP Warning: Declaration of UploadPluginForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/plugins/form/UploadPluginForm.inc.php on line 22
• [x] PHP Warning: Declaration of GenreForm::execute($args, $request) should be compatible with Form::execute() in lib/pkp/controllers/grid/settings/genre/form/GenreForm.inc.php on line 18
• [x] PHP Warning: Declaration of GenreForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/settings/genre/form/GenreForm.inc.php on line 18
• [x] PHP Warning: Declaration of GenreForm::initData($args, $request) should be compatible with Form::initData() in lib/pkp/controllers/grid/settings/genre/form/GenreForm.inc.php on line 18
• [x] PHP Warning: Declaration of GenreGridHandler::initialize($request) should be compatible with SetupGridHandler::initialize($request, $args = NULL) in lib/pkp/controllers/grid/settings/genre/GenreGridHandler.inc.php on line 20
• [x] PHP Warning: Declaration of ManageLanguageGridHandler::initialize($request) should be compatible with LanguageGridHandler::initialize($request, $args = NULL) in lib/pkp/controllers/grid/settings/languages/ManageLanguageGridHandler.inc.php on line 18
• [x] PHP Warning: Declaration of LibraryFileAdminGridDataProvider::loadCategoryData($request, &$fileType, $filter = NULL) should be compatible with CategoryGridDataProvider::loadCategoryData($request, $categoryDataElement, $filter = NULL) in lib/pkp/controllers/grid/settings/library/LibraryFileAdminGridDataProvider.inc.php on line 19
• [x] PHP Warning: Declaration of LibraryFileAdminGridHandler::initialize($request) should be compatible with LibraryFileGridHandler::initialize($request, $args = NULL) in lib/pkp/controllers/grid/settings/library/LibraryFileAdminGridHandler.inc.php on line 20
• [x] PHP Warning: Declaration of PreparedEmailsGridHandler::authorize($request, $args, $roleAssignments) should be compatible with GridHandler::authorize($request, &$args, $roleAssignments) in lib/pkp/controllers/grid/settings/preparedEmails/PreparedEmailsGridHandler.inc.php on line 0
• [x] PHP Warning: Declaration of ReviewFormGridHandler::loadData($request) should be compatible with GridHandler::loadData($request, $filter) in lib/pkp/controllers/grid/settings/reviewForms/ReviewFormGridHandler.inc.php on line 0
• [x] PHP Warning: Declaration of PreviewReviewForm::fetch($args, $request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/settings/reviewForms/form/PreviewReviewForm.inc.php on line 0
• [x] PHP Warning: Declaration of PreviewReviewForm::initData($request) should be compatible with Form::initData() in lib/pkp/controllers/grid/settings/reviewForms/form/PreviewReviewForm.inc.php on line 0
• [x] PHP Warning: Declaration of ReviewFormElements::fetch($args, $request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/settings/reviewForms/form/ReviewFormElements.inc.php on line 0
• [x] PHP Warning: Declaration of ReviewFormForm::execute($request) should be compatible with Form::execute() in lib/pkp/controllers/grid/settings/reviewForms/form/ReviewFormForm.inc.php on line 18
• [x] PHP Warning: Declaration of ReviewFormForm::fetch($args, $request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/settings/reviewForms/form/ReviewFormForm.inc.php on line 18
• [x] PHP Warning: Declaration of ReviewFormForm::initData($request) should be compatible with Form::initData() in lib/pkp/controllers/grid/settings/reviewForms/form/ReviewFormForm.inc.php on line 18
• [x] PHP Notice: Only variables should be passed by reference in lib/pkp/controllers/grid/settings/roles/UserGroupGridCellProvider.inc.php on line 39
• [x] PHP Warning: Declaration of UserGroupGridHandler::renderFilter($request) should be compatible with GridHandler::renderFilter($request, $filterData = Array) in lib/pkp/controllers/grid/settings/roles/UserGroupGridHandler.inc.php on line 0
• [x] PHP Warning: Declaration of UserGroupForm::execute($request) should be compatible with Form::execute() in lib/pkp/controllers/grid/settings/roles/form/UserGroupForm.inc.php on line 19
• [x] PHP Warning: Declaration of UserGroupForm::fetch($request) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/grid/settings/roles/form/UserGroupForm.inc.php on line 19
• [x] PHP Warning: Declaration of SubmissionChecklistGridHandler::initialize($request) should be compatible with SetupGridHandler::initialize($request, $args = NULL) in lib/pkp/controllers/grid/settings/submissionChecklist/SubmissionChecklistGridHandler.inc.php on line 19
• [x] PHP Warning: Declaration of UserGridHandler::renderFilter($request) should be compatible with GridHandler::renderFilter($request, $filterData = Array) in lib/pkp/controllers/grid/settings/user/UserGridHandler.inc.php on line 0
• [x] PHP Warning: Declaration of & UserDetailsForm::execute($args, $request) should be compatible with UserForm::execute() in lib/pkp/controllers/grid/settings/user/form/UserDetailsForm.inc.php on line 18
• [x] PHP Warning: Declaration of UserForm::display($args, $request) should be compatible with Form::display($request = NULL, $template = NULL) in lib/pkp/controllers/grid/settings/user/form/UserForm.inc.php on line 18
• [x] PHP Warning: Declaration of UserForm::execute($args, $request) should be compatible with Form::execute() in lib/pkp/controllers/grid/settings/user/form/UserForm.inc.php on line 18
• [x] PHP Warning: Declaration of UserForm::initData($args, $request) should be compatible with Form::initData() in lib/pkp/controllers/grid/settings/user/form/UserForm.inc.php on line 18
• [x] PHP Warning: Declaration of BlockPluginsListbuilderHandler::initialize($request) should be compatible with MultipleListsListbuilderHandler::initialize($request, $args = NULL) in lib/pkp/controllers/listbuilder/settings/BlockPluginsListbuilderHandler.inc.php on line 17
• [x] PHP Warning: Declaration of AnnouncementSettingsForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/announcements/form/AnnouncementSettingsForm.inc.php on line 18
• [x] PHP Warning: Declaration of PKPAppearanceForm::execute($request) should be compatible with ContextSettingsForm::execute() in lib/pkp/controllers/tab/settings/appearance/form/PKPAppearanceForm.inc.php on line 18
• [x] PHP Warning: Declaration of PKPAppearanceForm::fetch($request) should be compatible with ContextSettingsForm::fetch($request, $params = NULL) in lib/pkp/controllers/tab/settings/appearance/form/PKPAppearanceForm.inc.php on line 18
• [x] PHP Warning: Declaration of ArchivingForm::execute($request) should be compatible with ContextSettingsForm::execute() in lib/pkp/controllers/tab/settings/archiving/form/ArchivingForm.inc.php on line 18
• [x] PHP Warning: Declaration of ArchivingForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/archiving/form/ArchivingForm.inc.php on line 18
• [x] PHP Warning: Declaration of EmailTemplatesForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/emailTemplates/form/EmailTemplatesForm.inc.php on line 18
• [x] PHP Warning: Declaration of NavigationMenuSettingsForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/navigationMenus/form/NavigationMenuSettingsForm.inc.php on line 18
• [x] PHP Warning: Declaration of PaymentMethodForm::execute($request) should be compatible with ContextSettingsForm::execute() in lib/pkp/controllers/tab/settings/paymentMethod/form/PaymentMethodForm.inc.php on line 18
• [x] PHP Warning: Declaration of PaymentMethodForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/paymentMethod/form/PaymentMethodForm.inc.php on line 18
• [x] PHP Warning: Declaration of PaymentMethodForm::initData($request) should be compatible with ContextSettingsForm::initData() in lib/pkp/controllers/tab/settings/paymentMethod/form/PaymentMethodForm.inc.php on line 18
• [x] PHP Warning: Declaration of PaymentMethodForm::readInputData($request) should be compatible with ContextSettingsForm::readInputData() in lib/pkp/controllers/tab/settings/paymentMethod/form/PaymentMethodForm.inc.php on line 18
• [x] PHP Warning: Declaration of PaymentMethodForm::validate() should be compatible with Form::validate($callHooks = true) in lib/pkp/controllers/tab/settings/paymentMethod/form/PaymentMethodForm.inc.php on line 18
• [x] PHP Warning: Declaration of PermissionSettingsForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/permissions/form/PermissionSettingsForm.inc.php on line 18
• [x] PHP Warning: Declaration of PKPReviewStageForm::fetch($request, $params = Array) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/reviewStage/form/PKPReviewStageForm.inc.php on line 18
• [x] PHP Warning: Declaration of SiteSetupForm::execute($request) should be compatible with PKPSiteSettingsForm::execute() in lib/pkp/controllers/tab/settings/siteSetup/form/SiteSetupForm.inc.php on line 20
• [x] PHP Warning: Declaration of SiteSetupForm::fetch($request, $params = NULL) should be compatible with Form::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/siteSetup/form/SiteSetupForm.inc.php on line 20
• [x] PHP Warning: Declaration of SiteSetupForm::initData($request) should be compatible with PKPSiteSettingsForm::initData() in lib/pkp/controllers/tab/settings/siteSetup/form/SiteSetupForm.inc.php on line 20
• [x] PHP Warning: Declaration of SubmissionStageForm::fetch($request, $params = NULL) should be compatible with ContextSettingsForm::fetch($request, $template = NULL, $display = false) in lib/pkp/controllers/tab/settings/submissionStage/form/SubmissionStageForm.inc.php on line 21
• [x] PHP Warning: Declaration of PKPUsageEventPlugin::getEnabled() should be compatible with LazyLoadPlugin::getEnabled($contextId = NULL) in lib/pkp/plugins/generic/usageEvent/PKPUsageEventPlugin.inc.php on line 0
• [x] PHP Warning: Declaration of ShibbolethAuthPlugin::register($category, $path) should be compatible with LazyLoadPlugin::register($category, $path, $mainContextId = NULL) in plugins/generic/ShibbolethAuthPlugin/ShibbolethAuthPlugin.inc.php on line 0
• [x] PHP Warning: Declaration of ExternalFeedBlockPlugin::getContents(&$templateMgr, $request = NULL) should be compatible with BlockPlugin::getContents($templateMgr, $request = NULL) in plugins/generic/externalFeed/ExternalFeedBlockPlugin.inc.php on line 0
• [x] PHP Warning: Declaration of LensGalleyPlugin::register($category, $path) should be compatible with LazyLoadPlugin::register($category, $path, $mainContextId = NULL) in plugins/generic/lensGalley/LensGalleyPlugin.inc.php on line 0

[asmecher]

(Be warned that the form stuff is potentially going to be a bunch of work. Things like plugin registrations are pretty trivial.)

[crism]

Thanks, @asmecher. I see you already fixed a few of these, too, after the 3.1.1-0 tag.

[crism]

Yuck… pretty sure the change to ContextSettingsForm::fetch() broke a bunch of stuff. Hard to track down the calls to it…

[asmecher]

PRs:

• https://github.com/pkp/ojs/pull/1968
• https://github.com/pkp/pkp-lib/pull/3702

OMP needs porting before the pkp-lib PR can be merged; apparently some form parameter orderings have changed.

[crism]

Oh, yuck… FileManager::downloadFile() wants a file _path_ as its first parameter, but its subclasses want an _ID_ as the first parameter… excellent opportunity for silent failure. The second parameter is also a revision, a user ID, or a media type… and it doesn’t trigger any warnings.

[asmecher]

Current PRs for this:

• https://github.com/pkp/ojs/pull/1968
• https://github.com/pkp/pkp-lib/pull/3702
  https://github.com/pkp/omp/pull/542

@crism, it doesn't look like the OMP or OJS tests passed -- have you looked at that?

[crism]

@asmecher, I think you’re right that monolithic PRs aren’t going to work… they get out of date w.r.t. master too quickly. I’ll drop those and submit focused vertical PRs for each interface.

[asmecher]

Merged those last 3 PRs -- thanks, @crism!

[asmecher]

@crism, one change to suggest to https://github.com/pkp/pkp-lib/pull/3866, https://github.com/pkp/omp/pull/561, and https://github.com/pkp/ojs/pull/2032 -- functions like deleteFileById should instead be called deleteById; naming the entity to be removed in the function name is redundant. (We removed that kind of redundancy from the DAOs some years back.)

[asmecher]

@crism, thanks for all your work on this. Can I ask a favour to help keep all the various PRs organized? Organize the PRs into groups and add them as comments here, e.g.:

PRs to harmonize Form::validate():

• https://github.com/pkp/pkp-lib/pull/3885
• https://github.com/pkp/ojs/pull/2044
• https://github.com/pkp/omp/pull/566

Then, after a review cycle (e.g. after you've tweaked one of those PRs), add a new comment here to let me know that you're done making changes to the batch, e.g.:

link to comment listing PRs goes here is ready for another look!

[crism]

Trio of getRequest() and getApplication() harmonizations:

• #3847
• pkp/ojs#2028
• pkp/omp#556

(edit: merged)

[crism]

Trio of FileManager harmonizations:

• #3866
• pkp/ojs#2032
• pkp/omp#561

[crism]

Trio of Form::fetch() harmonizations:

• #3879
• pkp/ojs#2037
• pkp/omp#563

[crism]

Trio of Form::initData() harmonizations:

• #3883
• pkp/ojs#2042
• pkp/omp#564

[crism]

Trio of Form::readInputData() harmonizations:

• #3884
• pkp/ojs#2043
• pkp/omp#565

[crism]

Trio of Form::validate() harmonizations:

• #3885
• pkp/ojs#2044
• pkp/omp#566

[NateWr]

Nice work @crism! I've looked at the Request PRs and they look good. Can you just rebase to fix the merge conflicts and I'll merge?

[crism]

@NateWr, the getRequest trio should be good to go.

[NateWr]

The request trio is all merged. Thanks @crism. @asmecher you're up! :)

[crism]

Trio of Form::execute() harmonizations:

• #3888
• pkp/ojs#2046
• pkp/omp#568

[crism]

Trio of GridCellProvider harmonizations:

• #3895
• pkp/ojs#2048
• pkp/omp#569

[crism]

Trio of GridDataProvider harmonizations:

• #3897
• pkp/ojs#2050
• pkp/omp#570

[crism]

Trio of GridHandler harmonization PRs:

• #3907
• pkp/ojs#2057
• pkp/omp#576

[crism]

Trio of GridRow harmonizations:

• #3908
• pkp/ojs#2058
• pkp/omp#577

[asmecher]

Here are all the changes currently in progress:

• [x] [getRequest() and getApplication() harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403865482)
• [x] [FileManager harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403179600)
• [x] [Form::fetch harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403179638)
• [x] [Form::initData harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403179706)
• [x] [Form::readInputData harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403179761)
• [x] [Form::validate harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403179817)
• [x] [Form::execute harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403593378)
• [x] [GridCellProvider harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403865482)
• [x] [GridDataProvider harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-403932506)
• [x] [GridHandler harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-404603405)
• [x] [GridRow harmonization](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-404632371)

[asmecher]

@crism, I've reviewed all of the open PRs and there's something needed on each of them, mostly test failures. I summarized them all in https://github.com/pkp/pkp-lib/issues/3578#issuecomment-404679076 for easy access (they're getting buried in history) -- I'll try to keep that up to date.

[crism]

I’ve rebased the FileManager changes. The tests are failing in ojs and omp on a plugin Composer call; I’m not sure why.

[crism]

@asmecher, it looks like the FileManager trio is good to go; all the blocks have been cleared out of the way. Now that that’s done, the other changes should go smoothly, too (knock on wood).

[crism]

@asmecher, Form::execute() is ready to go.

[crism]

@asmecher, Form::fetch() is ready to go.

[crism]

@asmecher, Form::initData() is ready to go.

[asmecher]

4 down, 7 to go, @crism!

[crism]

@asmecher, the outstanding Form changes have been rebased. I’ll wait on those before moving on…

[asmecher]

Form::fetch stuff merged, waiting on the tests for the others! Thanks, @crism.

[crism]

I think we need to do these one at a time because they step on each others’ toes. Not sure if this is better than a giant monolithic PR or not. d-: The Form::execute() changes are:

• #3888
• pkp/ojs#2046
• pkp/omp#568

[asmecher]

@crism, thanks, I've merged the other two Form-related entries that passed testing (and checked them off the list). There's still a merge conflict on another one that I've just noted.

[asmecher]

Great -- merged the other Form change. Thanks for all the work, @crism.

[crism]

Hopefully the rest of these don’t step on each others’ toes as much as the various Form ones. GridCellProvider:

• #3895
• pkp/ojs#2048
• pkp/omp#569

[crism]

GridDataProvider:

• #3897
• pkp/ojs#2050
• pkp/omp#570

[asmecher]

@crism, both of the above two sets link to the same pkp-lib PR; is that a typo?

[crism]

GridHandler:

• #3907
• pkp/ojs#2057
• pkp/omp#576

[crism]

@asmecher, fixed the GridCellProvider PR.

[asmecher]

@crism, see this comment re: the GridCellProvider pkp-lib PR!

[crism]

@asmecher, fixed the GridCellProvider PR. Also GridHandler ready to go, pending tests:

• #3907
• pkp/ojs#2057
• pkp/omp#576

[crism]

PKPSubmissionFileDAO::fromRow():

• pkp/ojs#2098
• pkp/omp#589

[crism]

Plugin:

• pkp/ojs#2099

[crism]

PKPUserSettingsDAO:

• #4001 (almost a round number…)
• pkp/ojs#2100 (hooray for round numbers!)
• pkp/omp#590

[crism]

@asmecher, there’s just one outstanding change I’m aware of, involving PKPHandler and its subclasses, which is waiting on a merge of GridHandler.

[asmecher]

@crism, the earlier list is completely checked off -- kudos!

Starting a new summary list based on some of the things you just added. Please let me know if I missed any.

• [x] [PKPSubmissionFileDAO::fromRow()](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-413952040)
• [x] [PKPUserSettingsDAO](https://github.com/pkp/pkp-lib/issues/3578#issuecomment-414000665)

[crism]

Last trio of PRs, for PKPHandler:

• #4004
• pkp/ojs#2101
• pkp/omp#591

[asmecher]

@crism, all merged! One of the merges automatically closed this issue -- a message from above, perhaps?