Pkp-lib: [OJS] OJS 3.1.0.1 adding a participant with Safari does not close the modal window

[ajnyga]

Hi,

Tagging @NateWr.

One of our editors reported that when assigning users to a submission, the modal window does not close after clicking "OK". The user is assigned though and you can just close the window from the "X" button, but in other browsers the window is closed automatically.

I was able to reproduce this with a clean installation of 3.1.0.1 and Safari 11 on Mac OS X 10.

[NateWr]

Confirmed with my iPad. In my case, the user is not actually assigned.

I don't have access to the console there. Do you see any messages in the browser's console?

[ajnyga]

Error: Syntax error, unrecognized expression: #submissionEditorDecisionsDiv,#copyeditingEditorDecisionsDiv,[id^=reviewDecisionsDiv jquery.min.js:554

[NateWr]

Bingo! Missing the closing ] in the attribute value selector.

https://github.com/pkp/pkp-lib/blob/master/js/controllers/grid/users/stageParticipant/StageParticipantGridHandler.js#L38-L40

[carzamora]

hi @NateWr, if I add this closing ] should work good? or is better wait to release 3.1.1?

[NateWr]

@t4x0n I think so. If you're able to test the fix for me that'd be great!

[carzamora]

@NateWr is not working for me on iOS neither MacOS... I think is another problem but I can't confirm it ... in Chrome console you can see the error too!

[carzamora]

maybe the problem is jQuery 1.11.0... I want to try change to 1.11.3 but I am not sure about how :/

[ajnyga]

After adding the closing ] I am not seeing the problem anymore. No errors with Safari 11.0.3. This is in the current master branch.

edit: same thing with 3.1.0.1, adding that removes the problem and I do not get any javascript errors with Safari anymore.

@t4x0n try disabling the minified setting from config.inc.php after doing the change to the js. You are probably getting the old version served from cache.

[carzamora]

I am trying in Safari 11.0.3 too but not with the master branch, with OJS 3.0.1-1

maybe a have troubles with my files in cache because I can't make changes... sorry I am not helping

[ajnyga]

the js cache seems to be especially hard to empty sometimes, but disabling the minified setting usually helps.

[carzamora]

Yes! thanks @ajnyga it is working now! I am not seeing the problem anymore!

[NateWr]

Thanks to both of you. I've confirmed the fix as well.

PR:
https://github.com/pkp/pkp-lib/pull/3473

Tests:
https://github.com/pkp/ojs/pull/1875

[NateWr]

Merged.