Pkhex: Sword and Shield Legality issues

[NinFanBoyFTW]

Hey just wanted to let you know that I am loving the new PKHeX and I was so happy to see you update it with Sword and Shield this quickly.

As for the legality, I know everything is very preliminary right now but I thought I might as well post some of my pokemon that are showing up as illegal so you can either see whats wrong, or so we can check this later after more legality checks are put in. Thanks again
001.zip

[Masamune3210]

if examples are needed I have about 3 boxes of Pokemon and roughly a 3rd of them are being reported with various errors, can dump them just say the word

[SciresM]

@deadair3210 send them to me -- I'd guess most are static encounters that need tagging.

[Masamune3210]

Shield Pokemon Boxes.zip
Here you go, all of them are either normal captures or pokemon given to the player

[AnalogMan151]

A few more things:

https://github.com/kwsch/PKHeX/blob/627a23695638d9c88cbcf2d0930fe044bbebf842/PKHeX.Core/Legality/Tables/Tables8.cs#L236

I'm pretty sure this is supposed to be {(int)Species.MrRime, 1},

Next, the Rage Candy bar is listed an an unobtainable item here:
https://github.com/kwsch/PKHeX/blob/627a23695638d9c88cbcf2d0930fe044bbebf842/PKHeX.Core/Legality/Tables/Tables8.cs#L341
but I have one in my inventory. Can't be positive on where I got it but pretty sure it was either a reward from one of the battle cafés or by spending watts with an NPC.

[PandaUnit-TWL]

I've got about 10 false flags for legality too. What they all have in common is they were either obtained in a raid battle or in the wilds as the large overpowered roamers. Even so not all of my wild area catches show up illegal, I think all (or most) of my raid catches have. The legality checker can't match any of their origins.
Flagged.zip

If I set the pkm I know I got from raids to have their hidden ability, they show up as legal. It's as if the checker only wants to the hidden abilities in raid pkm, even though there is only just a chance they'll have one.

Skuntank, Machoke, and Pelipper, who I caught as a extra large out of grass roamers, they have the same origin matching legality fail but the hidden abilities don't fix anything.

[ReignOfComputer]

Raid and over-leveled Pokemon in Wild Area are not checked for yet.

[PandaUnit-TWL]

Ah, ok. Well as long as I'm here thanks for all the work you put into this guys.

[architdate]

Just noting down the issue with the darmanitan forme being 0 which causes invalid form outside of battle error

Edit: fixed through 2b76fe1

[ReignOfComputer]

Check.zip

Condensed Pokemon from above and RoC's PC that are still illegal after latest additions. These are still illegal because:

• Cross-boundary Pokemon (e.g. Pokemon from Rolling Fields that was encountered in Dappled Grove)
• Nest Encounter
• Impossible to add to Static Encounter list (e.g. more than 1 Rhyhorn as a Static Encounter, varying levels, but contributed Rhyhorn is at post-game Level)

[architdate]

Another thing to note would be that formes of silvally are also not recognized as valid encounters. (Normal type holding something is recognized, but a fire forme holding fire memory isn't recognized)

[AnalogMan151]

In regard to TR taught moves showing as illegal is this line here:
https://github.com/kwsch/PKHeX/blob/686f69484d022b5a1c82664ccbe64bf5e1593006/PKHeX.Core/Editing/CommonEdits.cs#L580
supposed to reference Legal.TMHM_SWSH instead of Legal.Pouch_TMHM_SWSH?

[ReignOfComputer]

Legality Research.zip

Condensed Pokemon from above and other sources that still fail Legality Checks, classified.

[ReignOfComputer]

Legality Research.zip

Latest version, grouped up into:

• [ ] Cross Boundary
• [ ] Other Wild Area
• [x] Raids
• [x] Gigantamax
• [x] Invalid Move
• [x] Shedinja

[KurushiiEX]

Cleffa/Clefairy/Clefable are coming up as Hidden Ability not available, but their abilities are listed as Hidden multiple times in the raid encounter list Kaphotics tweeted.

[kwsch]

@KurushiiEX The initial list was incorrect. The actual value translation was figured out after the games were played more thoroughly.

[piapple1]

Hi, I am generating a female indeedee and it says legal then I try and trade online and it is blocked. I tried playing with location and level met to match a den and that did not work either. Origin game was set to sword each try because I was trying to match an OT. Here is the pokemon file. any help would be great thanks
876-01 - Indeedee - D0D33C72010B.zip

Update: I realized that extrasensory is a male only move but I don't think the legality checker checks that yet.

[PP-theSLAYER]

I'll like to add that these should be illegal:
Bred Bulbasaur line
Bred Squirtle line
Bred Kantonian Meowth line (Kantonian Meowth cannot be bred in SWSH; Always Galarian version)
Bred Alolan Meowth line (Alolan Meowth cannot be bred in SWSH w/o parent)
Bred Kantonian Ponyta line
Bred Kantonian Farfetch'd line
Bred Kantonian Weezing line
Bred Hoennian Zigzagoon line
Bred Johtonian Corsola
Bred Unovan Darumaka
Bred Unovan Yamask
Bred Alolan Starters

[AnalogMan151]

Bred Kanto Meowth and bred Unova Yamask are possible in the game. You can get a Unova Yamask via trade and then you can breed it by having it hold an Everstone while breeding. The result will be a Unova Yamask. Kanto Meowth can be obtained via mystery gift and bred the same way.

[PP-theSLAYER]

Yeah I realized my mistake. The rest wouldn't be, tho.

[Emzademon]

Noticed today that importing a Rotom-Mow set caused Leaf storm to be ticked as a TR relearn move and flagged as illegal.

Rotom-Mow @ Sitrus Berry
Ability: Levitate
Level: 50
EVs: 248 HP / 228 Def / 20 SpD / 12 Spe
Modest Nature
IVs: 0 Atk

• Protect
• Will-O-Wisp
• Volt Switch
• Leaf Storm

Not sure what interaction importing sets has but I've noticed it also clears the TR relearn moves, not sure if this was intentional or not? Wouldn't it be better to have it auto "give all" like how it auto levels a Pokemon to level 100, gives all PP Ups and such?

[kwsch]

@Emzademon works fine on latest commit, was fixed via https://github.com/kwsch/PKHeX/commit/22a5df518109d5107f6e6eef38c4544b5277b8a9

Having more relearn flags than necessary is a "fishy" metric, because you don't really spend TR's willy nilly. Having all of them is pretty indicative of hax, so PKHeX's logic tries to provide the bare minimum.

[kwsch]

Closing this catch-all as it has served its purpose. For reporting future issues, please categorize them and describe /why/ they are actually legal so that their (awkward) mechanics can be handled.