Pkhex: [Bug] Spanish GSC in-game trade Shuckle and Voltorb OT legality

[WEERSOQUEER]

I found another bug, this time with Shuckle's and Voltorb's Spanish OTs due to the characters _Í_ and _Á_ respectively.

While importing them directly into a slot in GSC retains their OT as is, the OT strings will get cut off if set into and from the controls, even if Modify PKM Info is turned off.

Here's an example:

Controls:

PK2 directly dragged+dropped to a slot:

Importing their PK2 files into SM/USUM only causes them to lose said characters:

That being said, trying to edit their OTs to the actual in SM/USUM results in "Invalid: OT from Generation 1/2 uses unavailable characters." While true you can't input those characters in Spanish RBY and GSC, these OTs are an exception.

https://bulbapedia.bulbagarden.net/wiki/User:SnorlaxMonster/In-game_trades_in_other_languages#Generation_II_2

Spanish.zip

[kwsch]

Á: char code BF
Í: char code C9

Bulbapedia doesn't have these character codes documented, looks like they only have for English / Japanese games...

The Crystal disassembly hasn't logged these either (maybe Spanish isn't on their radar)

I can add these two char codes in as well as add an edge case branch for the OT comparison (1/2->7+ space match); are there any others?

[WEERSOQUEER]

Here's what I've been able to document regarding Spanish characters in GSC:

à: ba
è: bb
é: bc
ù: bd
À: be
Á: bf
Ä: c0
Ö: c1
Ü: c2
ä: c3
ö: c4
ü: c5
È: c6
É: c7
Ì: c8
Í: c9
Ñ: ca
Ò: cb
Ó: cc
Ù: cd
Ú: ce
á: cf
ì: d0
í: d1
ñ: d2
ò: d3
ó: d4
ú: d5

They are all unused except for BF and C9, which again, is only used in those 2 in-game trade's OTs.

Edit: While on the subject of transferring, I just want to point out that the GSC German in-game trade Shuckle "MODRI" throws a legality error upon importing it to SM/USUM due to its OT GABRIELE being too long; it passes fine on GSC, but the _OT gender should be restricted to male only_ as all of them falsely pass due to it being female, more specifically for Crystal if it reads the Met Location of "Can't Tell."

[kwsch]

I just want to point out that the GSC German in-game trade Shuckle "MODRI" throws a legality error upon importing it to SM/USUM due to its OT GABRIELE being too long; it passes fine on GSC, but the OT gender should be restricted to male only as all of them falsely pass due to it being female, more specifically for Crystal if it reads the Met Location of "Can't Tell."

https://github.com/kwsch/PKHeX/blob/71fdd01a930433d04cacc32211f2febbb389ed0b/PKHeX.Core/Legality/Verifiers/TrainerNameVerifier.cs#L119-L125

What exactly happens when the German Shuckle is transferred naturally? (pls pk2/7 me lol)

[WEERSOQUEER]

What exactly happens when the German Shuckle is transferred naturally? (pls pk2/7 me lol)

I put in the German Shuckle that was obtained from both GS as well as Crystal into a Silver and Crystal save, and also for research inserted them again, but with their OT gender set to female (hacked). They all passed, however, the ones with the modified OT gender Transported from my Silver were automatically changed to male by the app, while the ones Transported from Crystal kept the modified OT gender, which is obviously hacked.

I included them in 2 folders: one with the Pokemon inserted into and Transported from Silver and the other from Crystal. (The PK2s with Can't Tell as a Met Location are from Crystal.)

Shuckle.zip

[SatoMew]

The Crystal disassembly hasn't logged these either (maybe Spanish isn't on their radar)

All languages will be added eventually. Here's the current location for the Spanish Crystal character map.