Pkhex: Hidden power import issues?

[architdate]

this import seems to translate to the following in PKHeX

I'm assuming that this is because of the IV functionality implemented in the commit bfe4f32
However because of this it seems to be directly disregarding the Hidden power if any sort of IVs are specified. My opinion on solving this would be to check if the provided IVs (in this case Atk = 0) satisfy the Hidden Power requirement. If they do not, then keep the specified IVs as they are and then try to implement Hidden power with the unspecified IVs. If implementation of HPs is impossible because of conflict in provided IVs and provided Hidden Power, then it should give priority to the provided IV distribution.

Keep up the work on PKHeX btw! Its amazing to see it grow so far from the ORAS days!

Rotom-Heat @ Choice Scarf
Ability: Levitate
EVs: 252 SpA / 4 SpD / 252 Spe
Timid Nature
IVs: 0 Atk
- Defog
- Overheat
- Volt Switch
- Hidden Power [Ice]

[kwsch]

Ugh, Showdown started omitting flawed IVs in the output (as they can be hyper trained to 31). 31/0/31/31/31/31 is HP Dragon. Showdown conversion was initially implemented before Hyper Training existed :)

Probably will have to add special handling for setting a Hidden Power Type (rather than using Showdown's Gen6 IVs). The initial code was overwriting Showdown's IVs, now it's only updating with specified IVs; it will need to double check Showdown's provided IVs -- if it doesn't match the specified hidden power, it should fiddle with the other unspecified IVs until the hidden power is matched.

[architdate]

That was fast! Thanks for the fix! I don't have access to my PC to look through the code currently, but just to clarify, this is permuting flawless IVs between 30 and 31 to find the first valid HP combination while respecting user specified IVs too correct?

[kwsch]

Yes.
It gets the index of all unspecified IVs (which are flawless [31]) and bitflips them (changing the order every attempt) to find a combination that results in the desired HP Type.