Pixi.js: PIXI.extras.TilingSprite#destroy does not pass options to super

Created on 4 May 2017  路  8Comments  路  Source: pixijs/pixi.js

PIXI.extras.TilingSprite extends PIXI.Sprite

is it correct that no options are passed to super in destroy method?

馃敟 High Priority 馃暦 Bug
Source
picture lucap86

Most helpful comment

seems the same with PIXI.extras. AnimatedSprite

picture lucap86 on 4 May 2017
👍2

All 8 comments

no, its not. Make a PR?

ivanpopelyshev picture ivanpopelyshev on 4 May 2017

Never mind, here it is :)

ivanpopelyshev picture ivanpopelyshev on 4 May 2017
👍1

thanks i was forking repo :)

lucap86 picture lucap86 on 4 May 2017

@lucap86 It'll be handy when you find another small critical bug

ivanpopelyshev picture ivanpopelyshev on 4 May 2017
❤1 👍1

seems the same with PIXI.extras. AnimatedSprite

lucap86 picture lucap86 on 4 May 2017
👍2

adjusted PR.

ivanpopelyshev picture ivanpopelyshev on 4 May 2017

Merged. Thanks @lucap86 for finding this.

bigtimebuddy picture bigtimebuddy on 4 May 2017
🎉1

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

lock[bot] picture lock[bot] on 24 Feb 2019
Was this page helpful?
0 / 5 - 0 ratings

Related issues

gigamesh picture gigamesh  路  3Comments
Darker picture Darker  路  3Comments
lunabunn picture lunabunn  路  3Comments
lucap86 picture lucap86  路  3Comments
neciszhang picture neciszhang  路  3Comments