Pipenv: Bright white is not readable on black-on-white terminal

[codl]

pipenv uses "bright white" (bold white) liberally for emphasis, which is unreadable if one's terminal has a white background, turning important warnings into some sort of mad libs:

it should instead use the escape code for bold, without specifiying a colour:

>>> print("Your \033[1mPipfile\033[m now contains pinned versions")

[uranusjr]

545 (also #660 for more detail on the off-white/off-black suggestion).

[codl]

ok

what about my suggestion to use plain bold though

[codl]

im also not a fan of the suggestion that this is irrelevant because configurable, and that black-on-white is so uncommon

both xterm and urxvt default to black on white with white set to... white. various libvte terminals default to white on black with non-off-black-black, and have the opposite as a preset

seems wild to me that pipenv would not be usable on stock xterm

[kennethreitz42]

@codl open a pull request to crayons.py to give it bold without white.

[kennethreitz42]

i did it

[kennethreitz42]

https://github.com/kennethreitz/pipenv/commit/1f1e9423688ec6c26c7214c21c8eda52f2c81d36

[kennethreitz42]

7.9.3 released, which fixes this.

[kennethreitz42]

I didn't know you could do bright without specifying a color 😆

[codl]

thanks!

[kennethreitz42]

thanks for the persistence!

[kennethreitz42]

✨🍰✨