Pipenv: Use tool to track test coverage

Created on 23 Sep 2017  路  10Comments  路  Source: pypa/pipenv

It looks like a few things don't have coverage at the moment (eg #656) - it might be good to start using a tool that reports PR coverage status to try and encourage test coverage increases :-)

Most helpful comment

we wrote some extensive integration tests last night:

https://github.com/kennethreitz/pipenv/blob/master/tests/test_pipenv.py

All 10 comments

we need better tests first :)

The idea of this tool would be to try and encourage you to add tests when adding new features ;-)

For example https://github.com/kennethreitz/pipenv/commit/eb2e798ab01a46a5336067b60db23cfb3307b95f#diff-e1e68886e05fef92bb74ed1699e5179e didn't add any tests :-)

Although that instance would likely have been caught by flake8, if we could get it re-enabled?

yeah, I think this is a good idea. it would be great to see which parts of the code are untested. it's hard to tell which tests to start adding without it

here's an example of coveralls: https://coveralls.io/github/AlJohri/craigslist?branch=master

i'd like to leave my project's lifecycle to myself, thank you.

ah, sorry for overstepping

once we settle down with adding more features, we can add more tests. no point in adding them now, when we're in a rapid development cycle, as it'll just slow us down.

we wrote some extensive integration tests last night:

https://github.com/kennethreitz/pipenv/blob/master/tests/test_pipenv.py

Awesome! :-)

I didn't write any of the existing tests, so i don't want to touch them. was easier to start over :)

Was this page helpful?
0 / 5 - 0 ratings