Pipelines: [frontend] Add pagination to Artifact list

Created on 17 Mar 2021  路  3Comments  路  Source: kubeflow/pipelines

What is the issue

Discussion: https://github.com/kubeflow/pipelines/pull/5311#pullrequestreview-613890507

It is hard to scale when there are many artifacts to show on Artifact list. We should implement something that API can accept pageSize and pageToken like listPipelines.

It might require update on backend API, or we can implement this during KFPv2 implementation, because it touches metadata store communication.

/kind bug
/area frontend

@Bobgy

arefrontend kinbug

All 3 comments

Hello!

There are two old issues about this, so let's link to them:

Moreover, to fix this I suggest we rely on existing pagination support of the backend, thus making the the UI backwards compatible.

  1. MLMetadata supports pagination in GetArtifacts, GetExecutions, and GetContexts APIs since 0.23.0 (release notes)
  2. MLMetadata support pagination in GetExecutionsByContext and
    GetArtifactsByContext APIs since 0.25.1 (release notes)
  3. KFP manifests deploy MLMetadata version 0.25.1 (source)

Therefore, it's just a matter of

  1. updating the client used by the UI, and
  2. update the UI code to show pages similar to runs list, experiments list, ...

In the end, there will be no breaking changes, no backend API changes, or different metadata store communication. What do you think?

Yes, the original plan was to support pagination when backend supports that. And the backend support has already been released as @elikatsis pointed out.

Suggest close either this issue or the existing issue, so that we do not have two threads for the same topic

Thank you @elikatsis and @Bobgy for the reference! It makes sense to change client since metadata has already supported pagination. I will close this issue here. Since we have linked this issue to the previous ones, we can find the reference for our decision on making client changes for supporting pagination.

Was this page helpful?
0 / 5 - 0 ratings