Pipelines: Backend dependency cleanup - remove bazel

Created on 10 Mar 2020  路  8Comments  路  Source: kubeflow/pipelines

Will help to reduce backend build time and easy dependency version bumping

arebackend help wanted prioritp2

Most helpful comment

Since we have solved the last out standing point here I believe this can be removed. https://github.com/kubeflow/pipelines/issues/3250#issuecomment-744114178 @Bobgy

All 8 comments

All high priority tasks have been done.

Right now, bazel is only used to generate swagger json definitions from proto and that's a offline task.
Contributions welcomed on finishing the last step to remove bazel, but I believe it's not high priority because generated code are commited in the repo.

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

For the last issue, I just noticed we had a makefile for generating API swagger definitions from proto (before we used bazel):
https://github.com/kubeflow/pipelines/blob/2f3a686e545b671d3d1ce96bbcc07b18cb905a87/backend/api/Makefile

We may use it as a reference when migrating bazel based generation script back.

A quick recap of remaining issue:

jingzhang36 had an WIP PR for removing bazel from proto generation script: https://github.com/kubeflow/pipelines/pull/4393

but it went into the wrong direction, because we need the generated code checked in the repo, rather than during docker build step.

/cc @NikeNano
this is the tracker issue for removing bazel, in case you didn't know it.

Since we have solved the last out standing point here I believe this can be removed. https://github.com/kubeflow/pipelines/issues/3250#issuecomment-744114178 @Bobgy

A long time headache is over : )

Succes :)

Was this page helpful?
0 / 5 - 0 ratings