While (briefly) debugging #2998 with @skaegi, I noticed that the images we set as default flag values in cmd/controller differ from the images we set in config/controller.yaml.
I'm not sure how much of a problem this is, but it can be confusing. We should probably keep these up to date and matching somehow, but I'm not sure the best way.
dlorenc
All 6 comments
An example of the confusion: the flag for "shell-image' defaults to busybox, while the deployment uses gcr.io/distroless/base:debug
dlorenc
on 24 Jul 2020
/kind cleanup
dlorenc
on 24 Jul 2020
I think we should default the flags to "" and log.Fatal if they're unset. Having values in two places is confusing and error prone.
ImJasonH
on 25 Jul 2020
Found another one!
.ko.yaml configures the base image for the entrypoint image to be gcr.io/distroless/base:debug-nonroot. But tekton/publish.yaml writes a .ko.yaml file that configures its base to be busybox.
I'm not sure how to catch and fail on that kind of mismatch in the future, but should at least fix it for now.
ImJasonH
on 27 Jul 2020
Thanks for taking this on! Deleting the other defaults makes sense to me.
dlorenc
on 27 Jul 2020
@ImJasonH I think this can be closed now, thanks for sending all those PRs!
dlorenc
on 28 Jul 2020
Related issues
sujithjoseph
路
3Comments
silverlyra
路
4Comments
VeereshAradhya
路
3Comments
nader-ziada
路
4Comments
cnych
路
4Comments
Most helpful comment
I think we should default the flags to "" and log.Fatal if they're unset. Having values in two places is confusing and error prone.