Pipeline: Proposal: Add a default "image" for script mode

Created on 3 Dec 2019  Â·  11Comments  Â·  Source: tektoncd/pipeline

This would allow users to simplify yaml even further with script mode. Right now we require them to specify an image, but Tekton could default to something reasonable.

kinfeature prioritbacklog

Most helpful comment

This sounds tempting, but the questions in https://github.com/tektoncd/pipeline/issues/1676#issuecomment-561627587 (and likely more we'd uncover) make me think it's not worth jumping in to. Allowing operators or providers to configure their own defaults might also harm portability (script on platform A works because its default script image has ls with some flag, but breaks on platform B because its ls doesn't support that flag or something)

So ultimately I'm mildly -1 on it.

All 11 comments

/kind feature
/cc @ImJasonH

Questions we'd need to answer:

  • what shells or scripting environments should be included?
  • if platform providers can change the default image, what tools (at what versions) must be included to be considered compliant?
  • what's the base OS we should use by default and what traits of it should we require of other non-default platform provided overrides?
  • what's the versioning story for upgrading the version of whatever tools are available in the image?

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

@vdemeester: Reopened this issue.

In response to this:

/remove-lifecycle rotten
/remove-lifecycle stale
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Marking this for triage to get a sense from other OWNERS if we want this or not

This sounds tempting, but the questions in https://github.com/tektoncd/pipeline/issues/1676#issuecomment-561627587 (and likely more we'd uncover) make me think it's not worth jumping in to. Allowing operators or providers to configure their own defaults might also harm portability (script on platform A works because its default script image has ls with some flag, but breaks on platform B because its ls doesn't support that flag or something)

So ultimately I'm mildly -1 on it.

/close

Given the open questions above, and a general feeling that we'd need to provide lots of tools baked in to the image which we can't really predict in advance, I'm going to close this for now unless a really strong use case rears its head in future.

Was this page helpful?
0 / 5 - 0 ratings