Pip: Release 19.2

[pradyunsg]

THE TIME HAS COME FOR CHOOSING A RELEASE MANAGER!

---

More seriously, we're almost at July so we should probably figure out our RM and whether we should have a release.

[pradyunsg]

I'm up for it and am happy to defer it if someone wants to be the RM.

IMO, we have enough things in master to justify a new release (news/ has ~11 feature and bugfix files each, as on today).

[pradyunsg]

(accidentally assigned myself coz pressing p\ assigned me instead of pypa/pip-committers)

On that note, pinging @pypa/pip-committers.

[pradyunsg]

Hmm... Does this mean I am the release manager for 19.2?

[xavfernandez]

Hmm... Does this mean I am the release manager for 19.2?

That would be nice 😊.

I'd like to take care of one of the next, but for this one, I'm not sure I'll have the time to properly handle it.

[pradyunsg]

I'd like to take care of one of the next, but for this one, I'm not sure I'll have the time to properly handle it.

@xavfernandez What's your PyPI username?

[pradyunsg]

I'll make the release in this week, optimistically. 🙃

[xavfernandez]

@xavfernandez What's your PyPI username?

xafer

[pradyunsg]

Final TODO items:

• Python 2 deprecation message update
• Update vendored dependencies
• Release Engineering

[yan12125]

As a side note, currently invoke vendoring.update is broken (I encountered this issue when trying to patch html5lib in https://github.com/pypa/pip/pull/6728), and a possible fix is available at https://github.com/pypa/pip/pull/6606.

[xavfernandez]

Ideally, some basic documentation would be added for the new debug command...

[pradyunsg]

I won't have the bandwidth to add the docs for debug. If anything, I think I'll add a message saying "don't parse this output" and then we can address the lack of docs after the release.

If someone else wants to get that _done_, it's best to file a PR in the next 24 hours for it. I'm hoping to make the release this weekend or on Monday, if I'm feeling too tired.

[xavfernandez]

@pradyunsg I'm adding the basic files.

[xavfernandez]

Cf #6731

[pradyunsg]

Awesome @xavfernandez! :D

[pradyunsg]

Filed #6732.

[pradyunsg]

Python 2 deprecation message update

6726

Update vendored dependencies

6749

[pradyunsg]

Okai. I'm happy to make a release with how master looks now.

There's a bunch of approved PRs wrt tests and code cleanups -- I'm going to merge them and trust that they don't break stuff. 🌈

[pradyunsg]

I'll be doing the release engineering today.

19.2 will be based off of https://github.com/pypa/pip/commit/8582f7e40f3083e6713057122edb1143a1cd784.

[pradyunsg]

19.2 has been released. May there not be any bug reports. ;)

• Uploaded on PyPI: https://pypi.org/project/pip/19.2/
• Updated get-pip.py: https://github.com/pypa/get-pip/commit/67675315bad28a926dfcae979c8b70b6ba6211b0
• Sent mail to distutils-sig: https://mail.python.org/archives/list/[email protected]/thread/CHZ45EAXGIOD3D4OJR62656FQOTQCCXJ/
• Started a topic on Discourse: https://discuss.python.org/t/pip-19-2-is-now-available/2022

[pfmoore]

One thought - maybe the release note could mention that while the upgrade should be painless, we would (of course) recommend that users test the release before deploying in production, as with any other software release. (The idea being to try to prevent problems going widespread like the ones we had in the last release).

[genesem]

Command pip list -o don't work.
Getting following errors:

ERROR: Exception:
Traceback (most recent call last):
  File "c:\py3\lib\site-packages\pip\_internal\cli\base_command.py", line 188, in main
    status = self.run(options, args)
  File "c:\py3\lib\site-packages\pip\_internal\commands\list.py", line 156, in run
    packages = self.get_outdated(packages, options)
  File "c:\py3\lib\site-packages\pip\_internal\commands\list.py", line 164, in get_outdated
    dist for dist in self.iter_packages_latest_infos(packages, options)
  File "c:\py3\lib\site-packages\pip\_internal\commands\list.py", line 164, in <listcomp>
    dist for dist in self.iter_packages_latest_infos(packages, options)
  File "c:\py3\lib\site-packages\pip\_internal\commands\list.py", line 195, in iter_packages_latest_infos
    best_candidate = evaluator.get_best_candidate(all_candidates)
  File "c:\py3\lib\site-packages\pip\_internal\index.py", line 729, in get_best_candidate
    best_candidate = max(candidates, key=self._sort_key)
  File "c:\py3\lib\site-packages\pip\_internal\index.py", line 710, in _sort_key
    has_allowed_hash = int(link.is_hash_allowed(self._hashes))
  File "c:\py3\lib\site-packages\pip\_internal\models\link.py", line 213, in is_hash_allowed
    return hashes.is_hash_allowed(self.hash_name, hex_digest=self.hash)
AttributeError: 'NoneType' object has no attribute 'is_hash_allowed'

So rolled back to pip 19.1.1.
environment: windows7, python3.7 (x64), upgraded from 19.1.1 with command: python -mpip install -U pip

[cjerdonek]

AttributeError: 'NoneType' object has no attribute 'is_hash_allowed'

This is already known (and should be addressed soon with a new release): https://github.com/pypa/pip/issues/6772

[pradyunsg]

• 19.2.1 has been uploaded on PyPI!
• get-pip.py has also been updated.

[johnthagen]

@pradyunsg I didn't realize 19.2.1 was released until finding this issue. Do the docs still need to be rebuilt? I only see 19.2 on https://pip.pypa.io/en/stable/news/.

Thanks.

[pradyunsg]

Ah, thanks for chiming in @johnthagen! This should be fixed in a bit.

I'd accidentally pushed the 19.2 tag again, when pushing tags, instead of pushing the 19.2.1 git tag. Corrected that error. :)

[pradyunsg]

Alrighty, all good then. :)

[johnthagen]

@pradyunsg Looks great now! :)

[pradyunsg]

There's gonna be a 19.2.2. My current plan is to cherry-pick the following off the 19.2.1 tag:

• https://github.com/pypa/pip/commit/2a5c23b3d5c47ebdb8c30aaf84aad36a645a1482 (fixes an issue with the typing import causing crashes: https://github.com/pypa/pip/issues/6824)
• https://github.com/pypa/pip/commit/7d29841ced8df7e3c4616ea7358f2f1ecc7c32a9
• https://github.com/pypa/pip/commit/3e73edd3e88b08fff82b5e1eb4936de3e43b91d6

I expect I'll make the release sometime next week so lemme know if there's any concerns w.r.t. this. :)

[pradyunsg]

Oh heck.

I completely forgot about this in PyCon Korea prep. Working on this now.

[pradyunsg]

ISTM that we need to update our release process notes for bugfix releases. :)

[pradyunsg]

• Built 19.2.2 off 082bc0411e9d17b3c80efed9237c61d7446515f5 (PR: #6860)
• Uploaded to PyPI.
• Updated get-pip.py.
• Made sure to push the tag this time. ^>^

[pradyunsg]

Okay, I'll be hopping onto a flight tomorrow evening -- ~20 hours from now. I'm plan to call it done with this release by then; barring any new bug reports of course. :)

[pradyunsg]

All done for 19.2 then.

Thanks everyone who contributed to this release and especially those who flagged issues and/or helped resolved them! ^>^

[pradyunsg]

The fix for #6885, needs to make it into 3.8.0's final beta, that's due tomorrow.

Thus, I'm cutting a 19.2.3 off 19.2.2, with just one merge cherry-picked: 54eedbd7b4e2a384ef981ad468c8175dcdfd93ce.

EDIT: including 0b23e2d68a7de096b75fe3ad290acd7239b6f8fa, since I don't wanna deal with merge conflicts.

[pradyunsg]

• [x] PyPI release
• [x] get-pip.py update
• [x] PR merge (#6920)
• [x] Tag push
• [x] CPython PR (https://github.com/python/cpython/pull/15483)

[pradyunsg]

All done!

[mihaic]

Shouldn't the "stable" release notes include this release?
https://pip.pypa.io/en/stable/news/
The "latest" release notes have it:
https://pip.pypa.io/en/latest/news/

[pradyunsg]

Hmm... seems like the docs build is failing.

[pradyunsg]

Okay, fixed that.

Managed a successful "stable" docs build with the older, non-YAML based configuration with different (older) file structure in the repository.