pip uses configparser's deprecated readfp

[dchudz]

• Pip version: 9.0.1
• Python version: 3.6.4
• Operating system: Mac OS X 10.12.4

Description:

pip install -r requirements.txt gives a deprecation warning. See below for detailed output.

Context on why I care: I contribute to another project that wants to turn on "deprecation warnings as errors". We can ignore this one without much trouble, but I thought I should mention it here.

What I've run:

$PYTHONWARNINGS="error::DeprecationWarning,default::DeprecationWarning:distutils" pip install -r requirements.txt
/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/distutils/__init__.py:4: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
  import imp
Requirement already satisfied: pip in /Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages (from -r requirements.txt (line 1))
Collecting pytest (from -r requirements.txt (line 2))
  Using cached pytest-3.4.1-py2.py3-none-any.whl
Requirement already satisfied: setuptools in /Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages (from pytest->-r requirements.txt (line 2))
Requirement already satisfied: py>=1.5.0 in /Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages (from pytest->-r requirements.txt (line 2))
Requirement already satisfied: six>=1.10.0 in /Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages (from pytest->-r requirements.txt (line 2))
Requirement already satisfied: pluggy<0.7,>=0.5 in /Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages (from pytest->-r requirements.txt (line 2))
Requirement already satisfied: attrs>=17.2.0 in /Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages (from pytest->-r requirements.txt (line 2))
Installing collected packages: pytest
Exception:
Traceback (most recent call last):
  File "/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages/pip/basecommand.py", line 215, in main
    status = self.run(options, args)
  File "/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages/pip/commands/install.py", line 342, in run
    prefix=options.prefix_path,
  File "/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages/pip/req/req_set.py", line 784, in install
    **kwargs
  File "/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages/pip/req/req_install.py", line 851, in install
    self.move_wheel_files(self.source_dir, root=root, prefix=prefix)
  File "/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages/pip/req/req_install.py", line 1064, in move_wheel_files
    isolated=self.isolated,
  File "/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages/pip/wheel.py", line 351, in move_wheel_files
    console, gui = get_entrypoints(ep_file)
  File "/Users/davidchudzicki/.virtualenvs/pip_repro/lib/python3.6/site-packages/pip/wheel.py", line 229, in get_entrypoints
    cp.readfp(data)
  File "/Library/Frameworks/Python.framework/Versions/3.6/lib/python3.6/configparser.py", line 761, in readfp
    DeprecationWarning, stacklevel=2
DeprecationWarning: This method will be removed in future versions.  Use 'parser.read_file()' instead.
(pip_repro)  /Users/davidchudzicki/piprepro
$pip list
DEPRECATION: The default format will switch to columns in the future. You can use --format=(legacy|columns) (or define a format=(legacy|columns) in your pip.conf under the [list] section) to disable this warning.
attrs (17.4.0)
pip (9.0.1)
pluggy (0.6.0)
py (1.5.2)
pytest (3.4.1)
setuptools (38.5.1)
six (1.11.0)
wheel (0.30.0)

[pradyunsg]

Nice catch and thanks for filing this issue @dchudz!

[pradyunsg]

This issue is a good starting point for anyone who wants to help out with pip's development -- it's simple and the process of fixing this should be a good introduction to pip's development workflow. :)

[Prashant47]

I would like to work on this issue.

[pradyunsg]

Go ahead. =)

[jklydev]

Looks like this was fixed in #3901

[pradyunsg]

This seems to have been fixed at some point as @JKiely points out since there's no reference to readfp in the codebase anymore.

[lock[bot]]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.