Pip-tools: README diagram does not display well on dark mode

Created on 1 Feb 2021  Â·  6Comments  Â·  Source: jazzband/pip-tools

  1. Enable GitHub Dark Mode: https://github.com/settings/appearance
  2. Open the pip-tools GitHub page

Screen Shot 2021-02-01 at 7 28 07 AM

Perhaps if the black text had a white outline it would help?

bug docs help wanted

All 6 comments

Hello @johnthagen,

Nice catch! Yes, indeed. White outlined labels would look better on a dark mode.

I'd like to address this issue. @atugushev: Do you mind assigning the issue to me?

@fhightower feel free to send a PR, I've marked you as an assignee.

@fhightower while you're on it, I have a comment to make. I don't like that the picture is PNG. It's much better to have it in SVG. So could you redraw it in vector and keep it in that format?

Also, verify the colors compat/contrast with more than one dark theme — GH has two darks (default and dimmed), and also, there are third-party mods like https://github.com/StylishThemes/GitHub-Dark.

Will do, thanks for the input.

Was this page helpful?
0 / 5 - 0 ratings