Pip-tools: Add @pytest.mark.network to tests which require the internet

Created on 15 Sep 2019  路  5Comments  路  Source: jazzband/pip-tools

What's the problem this feature will solve?

It would be good to split the parameterized, and revise the tests unnecessarily using online data, and mark any real unavoidable online tests with a pytest marker called 'internet' or 'online' so that I (and other packagers) could use the following.

_Posted in its original form by @jayvdb in https://github.com/jazzband/pip-tools/issues/887#issue-491806159._

Describe the solution you'd like

Add @pytest.mark.network to the following tests:

  • test_allow_unsafe_option
  • test_annotate_option
  • test_editable_package
  • test_editable_package_vcs
  • test_editable_top_level_deps_preserved
  • test_filter_pip_markers
  • test_generate_hashes_all_platforms
  • test_generate_hashes_verbose
  • test_generate_hashes_with_editable
  • test_generate_hashes_with_url
  • test_generate_hashes_without_interfering_with_each_other
  • test_get_hashes_local_repository_cache_miss
  • test_input_file_without_extension
  • test_locally_available_editable_package_is_not_archived_in_cache_dir
  • test_no_candidates
  • test_no_candidates_pre
  • test_pre_option
  • test_realistic_complex_sub_dependencies
  • test_stdin
  • test_url_package

Additional context

Following up #887.

PR wanted good first issue tests

All 5 comments

Hello
Can I work on this issue and send a pull request?

Hello @peymanslh,

Sure! Please, feel free to.

@atugushev
I sent a pr: #917

Thanks for the contribution @peymanslh! Would you like to work on another issue? 馃槑

@atugushev
Yes, sure!

Was this page helpful?
0 / 5 - 0 ratings

Related issues

blampe picture blampe  路  4Comments

vphilippon picture vphilippon  路  4Comments

sirex picture sirex  路  4Comments

kmontag picture kmontag  路  4Comments

rpkilby picture rpkilby  路  5Comments