Pino: remove the `silent` logger method

Created on 11 Jun 2018  路  7Comments  路  Source: pinojs/pino

We support silent as .a special public logger method, and test it but it's not in the docs

Most helpful comment

No. It鈥檚 really useful for tests.

All 7 comments

should we just remove it in the next semver-major?

No. It鈥檚 really useful for tests.

hey @jsumners can you elaborate on how it's useful for tests? I don't see the usefulness, and currently think we should remove but if it's significantly useful and there's no equally trivial alternative approach in testing then we should probably keep it

If you are testing a something that uses Pino for logging, and you don't want to see those logs all over your tests, it's helpful to be able to silence them.

Absolutely.. I think there's some confusion here. There's a method called logger.silent, its a no-op and there's no use case (that I can think of) for it. setting the level to silent, is different thing and the internal implementation doesn't rely on the existence of a silent method

Cool.

Perfetto - let's remove

Was this page helpful?
0 / 5 - 0 ratings

Related issues

NicolaiSchmid picture NicolaiSchmid  路  4Comments

ronag picture ronag  路  5Comments

yoshuawuyts picture yoshuawuyts  路  5Comments

cekvenich picture cekvenich  路  6Comments

callumlocke picture callumlocke  路  4Comments