Pim-community-dev: Product status permission issue

[wakqasahmed]

I'm reporting a Bug

Disabling/Disallowing the permission of the "Changing state of the product" behaves improperly in some cases.

Case 1: Product grid still have toggle icon and changing status is allowed still
Case 2: Product detail page has the button hidden (seems partially right as there should be an indicator (label/badge) telling the status of the product but non editable)

Steps to reproduce

1) System > User Management > Roles > Permissions Tab > Change state of the product > disallow

2) Go to product grid and you still see toggle status icon and can even disable/enable the product (wrong behavior in my opinion)

3) Go to product detail and you don't see the Enabled/Disabled button (partially right behavior in my opinion)

Thank You

[LaureBrosseau]

Hi @wakqasahmed,

Thanks for your ticket, I could reproduce the same behaviours.

For case 1, it's a bug.

For case 2, what would you expect on the Product Edit Form: a button Enabled/Disabled visible but not clickable?

Thanks a lot,
Laure

[wakqasahmed]

Hi @LaureBro,

Yep, for case 2, the Enabled/Disabled button visible (as disabled) but not clickable would suffice. It would keep the UI uniform and would serve the purpose of indicating the current status of the product.

Thank You

[BatsaxIV]

This PR fixes the first bug described.

For the second issue, it's not really a bug so I'll let the Akeneo team decided the best way to handle that case.

[phaseinducer]

Case 1 is fixed, thanks :wink:
@wakqasahmed If you really want to have the disabled button, it's possible to do it in your project. Don't hesitate to ask for help on the slack UG.