Pim-community-dev: config_prod.yml hardcodes apcu cache for doctrine

Created on 6 Apr 2016  路  5Comments  路  Source: akeneo/pim-community-dev

We're having a beautiful selection of cache drivers for doctrine, why would we hardcode any of them?

Maybe it should be moved to become one of the parameters in parameters.yml for the application. The pull request is pretty obvious, but let's have a discussion on this before I submit one.

Edit: clarifying my English.

Most helpful comment

@jmleroux thanks for a quick update. Sorry, maybe I was not that clear in my statement, I do not want Memcached to be the default option. I would love to have that configurable, not hardcoded.

All 5 comments

Hello @Xobb,

Memcached should not be a hard dependency.
This customization is quite easy and should maybe be documented, but not set by default.
To be honest, if doctrine metadata were cached in array in place of APC, i'm not sure it would have great impacts on perfs.

I totally agree with @Xobb , this configuration is basically an environment variable and should be moved to the parameters.yml file.

@jmleroux thanks for a quick update. Sorry, maybe I was not that clear in my statement, I do not want Memcached to be the default option. I would love to have that configurable, not hardcoded.

Hello @xobb,

After little discussion internally, we think that this variable is more related to project configuration than Akeneo PIM needs. You can add it to your parameters.yml in your project but I don't think we should add it to every projects. Moreover adding parameters to our parameters.yml file, will make them appear in our post composer install interactive command which can be confusing to new users. Last, a lot of parameters are like this one and adding it to our parameters.yml could kind of open the door to a lot of parameters.

As those files are versioned in your project, you can easily do it to fulfil your needs.

I hope that my answer is clear and not too "No way Jose" :)

Best regards,

Julien

@juliensnz

Thanks for your answer. We definitely found our way through this. Some things are not worth happening and this is one of them, that's why I never made a pull request. Thanks for insight and an awesome product you're creating.

Regards,
Paul Chubatyy

Was this page helpful?
0 / 5 - 0 ratings

Related issues

kanduvisla picture kanduvisla  路  3Comments

grabelle picture grabelle  路  3Comments

oliverde8 picture oliverde8  路  3Comments

ewallteam picture ewallteam  路  6Comments

henryktews picture henryktews  路  4Comments