Picongpu: Minor syntax error in SingleParticleTest configuration file

Created on 21 May 2021  路  3Comments  路  Source: ComputationalRadiationPhysics/picongpu

On branch "dev", there is a minor error in line 53 of ./share/picongpu/examples/SingleParticleTest/etc/picongpu/1.cfg:

TBG_openPMD="openPMD.period 1 --openPMD.file simData --openPMD.ext bp"

should be

TBG_openPMD="--openPMD.period 1 --openPMD.file simData --openPMD.ext bp"

This is a very tiny bug, but it will cause the example to fail.

bug examples

Most helpful comment

I will try to provide a request. I am just reading the guide. In the past, I submitted commits for other code repo on other servers.

All 3 comments

Thanks for pointing out the bug and giving a fix for it @mikewang2000 ! If you like to, please provide a pull request with this fix. Otherwise, someone from our team could do it.

I will try to provide a request. I am just reading the guide. In the past, I submitted commits for other code repo on other servers.

Nice! We have some documentation about it, perhaps that's what you meant. Basically you need to make a fork of the repository, then switch to the dev branch (will be master by default), make your new branch from there, commit your fix, push, and open a pull request from your branch to dev (again, will be master by default, there is a switch when opening up a pull request). Feel free to ask in case there are issues or question regarding that.

Was this page helpful?
0 / 5 - 0 ratings

Related issues

berceanu picture berceanu  路  4Comments

berceanu picture berceanu  路  3Comments

ax3l picture ax3l  路  4Comments

sbastrakov picture sbastrakov  路  3Comments

cbontoiu picture cbontoiu  路  3Comments