Picom: Fading doesn't affect window decorators.

[pushqrdx]

Platform

Fedora 29

GPU, drivers, and screen setup

Graphics:
Device-1: Intel Xeon E3-1200 v3/4th Gen Core Processor Integrated Graphics
driver: i915 v: kernel
Display: x11 server: Fedora Project X.org 1.20.3 driver: modesetting
unloaded: fbdev,vesa resolution: 1920x1080~60Hz
OpenGL: renderer: Mesa DRI Intel Haswell Desktop v: 4.5 Mesa 18.2.4

Environment

XFCE 4.12

Compton version

Latest. Compiled from next branch.

Compton configuration:

# Shadow
shadow = true;
shadow-opacity = 0.5;
shadow-radius = 5;
shadow-offset-x = -5;
shadow-offset-y = -5;
shadow-exclude = [
 "n:e:Notification",
 "n:e:Docky",
 "g:e:Synapse",
 "g:e:Conky",
 "n:w:*Firefox*",
 "n:w:*Chromium*",
 "n:w:*dockbarx*",
 "class_g ?= 'Cairo-dock'",
 "class_g ?= 'Xfce4-notifyd'",
 "class_g ?= 'Xfce4-power-manager'",
 "class_g ?= 'Notify-osd'",
 "_GTK_FRAME_EXTENTS@:c"
];
no-dock-shadow = true;
no-dnd-shadow = true; 

# Fading
fading = true;
# fade-delta = 30;
fade-in-step = 0.15;
fade-out-step = 0.15;
# no-fading-openclose = true;
# no-fading-destroyed-argb = true;
fade-exclude = [ ];

# Other
backend = "glx";
vsync = "opengl";

# OpenGL
glx-no-stencil = true;
glx-swap-method = "-1";
# xrender-sync = true;
# xrender-sync-fence = true;

# Window type settings
wintypes:
{
  tooltip = { fade = true; shadow = true; opacity = 0.90; focus = true; full-shadow = false; };
  dock = { shadow = false; }
  dnd = { shadow = false; }
  popup_menu = { opacity = 0.95; }
  dropdown_menu = { opacity = 0.95; }
};

Steps of reproduction

With fading enabled start, close or minimize, unminimize windows (borders will always appear before actual window content)

Expected behavior

All window content nicely fading either in or out.

Current Behavior

Window decorator isn't affected by fading.

[yshui]

Possibly related: #59

[pushqrdx]

@yshui after reading the issue I don't think they'r related.. _maybe i am mistaken_

[ncmprhnsbl]

well, i don't think i'm seeing this in openbox (with compton v4)
tested with fade-in-step = 0.01;

[yshui]

@pushqrdx I can't seem to reproduce this problem. Can you try the latest next?

[pushqrdx]

@yshui The issue was with the latest next branch. Simply minimizing, unminimizing or opening new windows have their borders appear first before the actual window content itself. The issue appears if you have fading. Try setting a longer fading duration.

[yshui]

@pushqrdx Interesting, I can reproduce it now, but only during fade out, and not reliably.

I will look into this.

[yshui]

@pushqrdx The direct cause seems to be that the body of the window disappeared from the pixmap when it is unmapped. Maybe xfwm4 is doing something that clears the body of window when it is unmapped.

[yshui]

There is _probably_ no much we can do.

I will look a bit more into this

[yshui]

@pushqrdx Does this problem happen with the xrender backend too?

[pushqrdx]

@yshui yeah I am pretty sure it happened regardless of backend used

[yshui]

Observation: I can only reproduce this during fading out of some opengl windows (my example is alacritty).

[yshui]

@pushqrdx I think this is somewhat related to how xfwm4 does thing. Could you also raise this issue to XFCE? They might have more information on this.

[yshui]

@pushqrdx As a follow up. Did you raise this issue to XFCE?

[pushqrdx]

@yshui Sorry for the delayed response, No i didn't as i thought it's compositor related.

[yshui]

@pushqrdx OK, I will do it myself then.

Filed: https://bugzilla.xfce.org/show_bug.cgi?id=15061

[yshui]

A fix seems to have been pushed upstream: https://git.xfce.org/xfce/xfwm4/commit?id=63a797b13023394937a89b41708e40d11b8fa5b2

Can you test and confirm if it works? @pushqrdx

[pushqrdx]

i am sorry for the late reply but it's kinda hard for me to confirm that at the moment (away from my setup), i'll try my best to confirm as soon as possible though.