Phpunit: Deprecate assertions (and helper methods) that operate on (non-public) attributes

[sebastianbergmann]

The following methods should be deprecated:

• assertAttributeContains()
• assertAttributeNotContains()
• assertAttributeContainsOnly()
• assertAttributeNotContainsOnly()
• assertAttributeCount()
• assertAttributeNotCount()
• assertAttributeEquals()
• assertAttributeNotEquals()
• assertAttributeEmpty()
• assertAttributeNotEmpty()
• assertAttributeGreaterThan()
• assertAttributeGreaterThanOrEqual()
• assertAttributeLessThan()
• assertAttributeLessThanOrEqual()
• assertAttributeSame()
• assertAttributeNotSame()
• assertAttributeInstanceOf()
• assertAttributeNotInstanceOf()
• assertAttributeInternalType()
• assertAttributeNotInternalType()
• attribute()
• attributeEqualTo()
• readAttribute()
• getStaticAttribute()
• getObjectAttribute

[TomasVotruba]

What should be used instead?

[gmponos]

@TomasVotruba https://github.com/sebastianbergmann/phpunit/issues/3339

[TomasVotruba]

@gmponos Thanks!

[geoidesic]

How do I figure out what replaces these?

[sebastianbergmann]

@geoidesic There is no replacement. The correct course of action is to refactor your code to not require dirty tricks like this.

[aogg]

@geoidesic There is no replacement. The correct course of action is to refactor your code to not require dirty tricks like this.

why not

[AlexMalikov94]

@sebastianbergmann What alternative using readAttribute(). If it deprecated almost for a secure reason what method I just need for use?

[sebastianbergmann]

@AlexMalikov94 There is no replacement. The correct course of action is to refactor your code to not require dirty tricks like this.

[AlexMalikov94]

@sebastianbergmann Yes you are right is dirty tricks but in the past developers used it just I think you have an alternative I see it is not. I just use another function more flexibly. I will contribute your code in the future.