Hi,
how exactly are you installing it?

On Thu, 28 Sep 2017 at 23:33, Saša Stamenković notifications@github.com
wrote:

Both composer global install and phar fail with:

PHP Fatal error: Uncaught Error: Class 'PHPStanVendor\Jean85\PrettyVersions' not found in phar:///usr/local/bin/phpstan.phar/bin/phpstan:23
Stack trace:

0 /usr/local/bin/phpstan.phar(4): require()

1 {main}

thrown in phar:///usr/local/bin/phpstan.phar/bin/phpstan on line 23

In addition, https://github.com/phpstan/phpstan/releases/tag/0.8.5 is
missing phar.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
https://github.com/phpstan/phpstan/issues/525, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGZuNTfOiZNRl0U3KZacejqhwmbPN-Sks5snBCTgaJpZM4Pn6w6
.

>

Ondřej Mirtes

ondrejmirtes on 29 Sep 2017

Composer

composer global require phpstan/phpstan

Phar

wget https://github.com/phpstan/phpstan/releases/download/0.8.4/phpstan.phar
mv phpstan.phar /usr/local/bin

umpirsky on 29 Sep 2017

Could not reproduce your problem:

Composer

~ $ composer global require phpstan/phpstan
Changed current directory to /Users/ondrej/.composer
Using version ^0.8.5 for phpstan/phpstan
./composer.json has been updated
Loading composer repositories with package information
Updating dependencies (including require-dev)
Package operations: 0 installs, 1 update, 0 removals
Writing lock file
Generating autoload files
ocramius/package-versions:  Generating version class...
ocramius/package-versions: ...done generating version class
~ $ /Users/ondrej/.composer/vendor/bin/phpstan --version
PHPStan - PHP Static Analysis Tool dev-master@651dd78

Phar

~ $ wget https://github.com/phpstan/phpstan/releases/download/0.8.4/phpstan.phar
--2017-09-29 16:30:13--  https://github.com/phpstan/phpstan/releases/download/0.8.4/phpstan.phar
Resolving github.com... 192.30.253.113, 192.30.253.112
Connecting to github.com|192.30.253.113|:443... connected.
HTTP request sent, awaiting response... 302 Found
Location: https://github-production-release-asset-2e65be.s3.amazonaws.com/49014795/ff480f42-8980-11e7-8f76-eb9f4ad07bb3?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20170929%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20170929T143014Z&X-Amz-Expires=300&X-Amz-Signature=9b1bb64ca89bb1eaa7433205ba55051b0b578ca1256330010b0793abf4857503&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Dphpstan.phar&response-content-type=application%2Foctet-stream [following]
--2017-09-29 16:30:14--  https://github-production-release-asset-2e65be.s3.amazonaws.com/49014795/ff480f42-8980-11e7-8f76-eb9f4ad07bb3?X-Amz-Algorithm=AWS4-HMAC-SHA256&X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20170929%2Fus-east-1%2Fs3%2Faws4_request&X-Amz-Date=20170929T143014Z&X-Amz-Expires=300&X-Amz-Signature=9b1bb64ca89bb1eaa7433205ba55051b0b578ca1256330010b0793abf4857503&X-Amz-SignedHeaders=host&actor_id=0&response-content-disposition=attachment%3B%20filename%3Dphpstan.phar&response-content-type=application%2Foctet-stream
Resolving github-production-release-asset-2e65be.s3.amazonaws.com... 54.231.98.152
Connecting to github-production-release-asset-2e65be.s3.amazonaws.com|54.231.98.152|:443... connected.
HTTP request sent, awaiting response... 200 OK
Length: 2434713 (2.3M) [application/octet-stream]
Saving to: ‘phpstan.phar’

phpstan.phar               100%[=======================================>]   2.32M  1.70MB/s    in 1.4s

2017-09-29 16:30:16 (1.70 MB/s) - ‘phpstan.phar’ saved [2434713/2434713]

~ $ chmod +x phpstan.phar
~ $ ./phpstan.phar --version
PHPStan - PHP Static Analysis Tool 0.8.4.0

ondrejmirtes on 29 Sep 2017

And the missing phar issue for 0.8.5 is a duplicate of #496.

ondrejmirtes on 29 Sep 2017

Not sure why this happens, file is there:

cat ~/.composer/vendor/jean85/pretty-package-versions/src/PrettyVersions.php
<?php

namespace Jean85;

use PackageVersions\Versions;

class PrettyVersions
{
    const SHORT_COMMIT_LENGTH = 7;

    public static function getVersion(string $packageName): Version
    {
        return new Version($packageName, Versions::getVersion($packageName));
    }
}

Looks like autoload issue.

umpirsky on 29 Sep 2017

Feel free to debug it, I have no idea what can it be caused by 😊 cc @Jean85

ondrejmirtes on 29 Sep 2017

My packages:

composer global show
Changed current directory to /home/umpirsky/.composer
doctrine/annotations           v1.5.0  Docblock Annotations Parser
doctrine/lexer                 v1.0.1  Base library for a lexer that can be used in Top-Down, Recursive Descent Parsers.
herrera-io/annotations         1.0.1   A tokenizer for Doctrine annotations.
herrera-io/box                 1.6.1   A library for simplifying the PHAR build process.
herrera-io/json                1.0.3   A library for simplifying JSON linting and validation.
herrera-io/phar-update         2.0.0   A library for self-updating Phars.
herrera-io/version             1.1.1   A library for creating, editing, and comparing semantic versioning numbers.
hirak/prestissimo              0.3.5   composer parallel install plugin
jean85/pretty-package-versions 1.0.2   A wrapper for ocramius/pretty-package-versions to get pretty versions strings
justinrainbow/json-schema      1.6.1   A library to validate a json schema.
kherge/amend                   3.0.5   Integrates Phar Update to Symfony Console.
kherge/box                     2.7.5   A tool to simplify building PHARs.
nette/bootstrap                v2.4.5  🅱 Nette Bootstrap: the simple way to configure and bootstrap your Nette application.
nette/di                       v2.4.10 💎 Nette Dependency Injection Container: Flexible, compiled and full-featured DIC with perfect...
nette/finder                   v2.4.1  Nette Finder: Files Searching
nette/neon                     v2.4.2  Nette NEON: parser & generator for Nette Object Notation
nette/php-generator            v3.0.1  🐘 Nette PHP Generator: generates neat PHP code for you. Supports new PHP 7.1 features.
nette/robot-loader             v3.0.2  🍀 Nette RobotLoader: high performance and comfortable autoloader that will search and autoloa...
nette/utils                    v2.4.8  🛠 Nette Utils: lightweight utilities for string & array manipulation, image handling, safe JS...
nikic/php-parser               v3.1.1  A PHP parser written in PHP
ocramius/package-versions      1.1.3   Composer plugin that provides efficient querying for installed package versions (no runtime IO)
phine/exception                1.0.0   A PHP library for improving the use of exceptions.
phine/path                     1.1.0   A PHP library for improving the use of file system paths.
phpseclib/phpseclib            2.0.6   PHP Secure Communications Library - Pure-PHP implementations of RSA, AES, SSH2, SFTP, X.509 etc.
phpstan/phpstan                0.8.5   PHPStan - PHP Static Analysis Tool
psr/log                        1.0.2   Common interface for logging libraries
pyrech/composer-changelogs     v1.5.1  Display changelogs after each composer update
seld/jsonlint                  1.6.1   JSON Linter
symfony/console                v3.3.6  Symfony Console Component
symfony/debug                  v3.3.6  Symfony Debug Component
symfony/finder                 v3.3.6  Symfony Finder Component
symfony/polyfill-mbstring      v1.5.0  Symfony polyfill for the Mbstring extension
symfony/process                v3.3.6  Symfony Process Component
tedivm/jshrink                 v1.2.0  Javascript Minifier built in PHP

umpirsky on 29 Sep 2017

The only strange stuff that I can see is Class 'PHPStanVendor\Jean85\PrettyVersions'.. Who's prepending PHPStanVendor in the namespace? PHPStan's PHAR has some autoloader additions?

Jean85 on 29 Sep 2017

@Jean85 That happens only for phar, with composer global it's just Jean85\PrettyVersions. I guess phar is prepending PHPStanVendor namespace to prevent collision with root.

umpirsky on 29 Sep 2017

Ok, understood. Since yours seems to be a config problem, can you post your environment spec?

Jean85 on 29 Sep 2017

@Jean85 What do you need?

php -v
PHP 7.1.9-1+ubuntu16.04.1+deb.sury.org+1 (cli) (built: Sep  2 2017 05:56:43) ( NTS )
Copyright (c) 1997-2017 The PHP Group
Zend Engine v3.1.0, Copyright (c) 1998-2017 Zend Technologies
    with Zend OPcache v7.1.9-1+ubuntu16.04.1+deb.sury.org+1, Copyright (c) 1999-2017, by Zend Technologies

cat /etc/issue
Ubuntu 16.04.3 LTS \n \l

umpirsky on 29 Sep 2017

Ok, you're using Linux like me. Are you using any other tech? Docker? VM? I cannot reproduce this too. Maybe you have some basic PHP extension disabled?

Jean85 on 2 Oct 2017

@Jean85 I use both vagrant and docker, but this (phpstan) is run on bare metal.

[PHP Modules]
calendar
Core
ctype
curl
date
dom
exif
fileinfo
filter
ftp
gd
gettext
hash
iconv
intl
json
libxml
mbstring
openssl
pcntl
pcre
PDO
pdo_sqlite
Phar
posix
readline
Reflection
session
shmop
SimpleXML
sockets
SPL
sqlite3
standard
sysvmsg
sysvsem
sysvshm
tokenizer
wddx
xml
xmlreader
xmlwriter
xsl
Zend OPcache
zlib

[Zend Modules]
Zend OPcache

umpirsky on 2 Oct 2017

Composer version in use?

BTW I'm not able to reproduce it with an isolated Docker env, using this command:

docker run --rm php:7.1.10-cli \
    curl -sS https://github.com/phpstan/phpstan/releases/download/0.8.4/phpstan.phar \
    && php ./phpstan.phar

Jean85 on 2 Oct 2017

👍1

Composer version 1.5.1 2017-08-09 16:07:22

Tried your docker command:

docker run --rm php:7.1.10-cli \
    curl -sS https://github.com/phpstan/phpstan/releases/download/0.8.4/phpstan.phar \
    && php ./phpstan.phar
Unable to find image 'php:7.1.10-cli' locally
7.1.10-cli: Pulling from library/php
aa18ad1a0d33: Pull complete 
29d5f85af454: Pull complete 
eca642e7826b: Pull complete 
dff3328cc427: Pull complete 
71edc0a65fa6: Pull complete 
7216d01164dd: Pull complete 
436741cba8f1: Pull complete 
Digest: sha256:8f2d107951a9295e4174b717ff46977ab053178ca602f9695c37e71a0922dba7
Status: Downloaded newer image for php:7.1.10-cli
<html><body>You are being <a href="https://github-production-release-asset-2e65be.s3.amazonaws.com/49014795/ff480f42-8980-11e7-8f76-eb9f4ad07bb3?X-Amz-Algorithm=AWS4-HMAC-SHA256&amp;X-Amz-Credential=AKIAIWNJYAX4CSVEH53A%2F20171002%2Fus-east-1%2Fs3%2Faws4_request&amp;X-Amz-Date=20171002T162239Z&amp;X-Amz-Expires=300&amp;X-Amz-Signature=38196c18ac0f584f11af175e47425e34b29d395d88cb877ed627cb909ff0df19&amp;X-Amz-SignedHeaders=host&amp;actor_id=0&amp;response-content-disposition=attachment%3B%20filename%3Dphpstan.phar&amp;response-content-type=application%2Foctet-stream">redirected</a>.</body></html>Could not open input file: ./phpstan.phar

Not sure why? Thanks.

umpirsky on 2 Oct 2017

Woha, it doesn't work for you even in an isolated Docker container? That's really strange!

Jean85 on 3 Oct 2017

@Jean85 My Docker skills are not very high but the commands is likely wrong, because the php ./phpstan.phar will be executed outside of the image because the && is processed by top-level bash, not by bash inside the image.

JanTvrdik on 3 Oct 2017

Thanks @JanTvrdik, you're absolutely right! My bash-fu is not so strong :smile:

The revised command is:

docker run --rm php:7.1.10-cli sh -c "curl -OJL https://github.com/phpstan/phpstan/releases/download/0.8.4/phpstan.phar && php ./phpstan.phar"

...and it works correctly for me:

$ docker run --rm php:7.1.10-cli sh -c "curl -OJL https://github.com/phpstan/phpstan/releases/download/0.8.4/phpstan.phar && php ./phpstan.phar"
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100   602    0   602    0     0   1248      0 --:--:-- --:--:-- --:--:--  1248
100 2377k  100 2377k    0     0  1009k      0  0:00:02  0:00:02 --:--:-- 1571k
curl: Saved to filename 'phpstan.phar'
PHPStan - PHP Static Analysis Tool 0.8.4.0

Usage:
  command [options] [arguments]

Options:
  -h, --help            Display this help message
  -q, --quiet           Do not output any message
  -V, --version         Display this application version
      --ansi            Force ANSI output
      --no-ansi         Disable ANSI output
  -n, --no-interaction  Do not ask any interactive question
  -v|vv|vvv, --verbose  Increase the verbosity of messages: 1 for normal output, 2 for more verbose output and 3 for debug

Available commands:
  analyse  [analyze] Analyses source code
  help     Displays help for a command
  list     Lists commands

Jean85 on 3 Oct 2017

Worked for me too, and now, I don't know how, but phpstan is magically working for me natively.

Mystery!

umpirsky on 3 Oct 2017

Maybe the project that you were using PHPStan on did something dodgy that broke everything?
BTW, happy to see your issue is resolved!

Jean85 on 3 Oct 2017

No idea. Thanks for your help!

umpirsky on 3 Oct 2017

I'm getting exactly the same error, it's somehow related to ~~the working dir~~ my own vendor/ folder.

[dado@fredo rollerworks-search]$ docker run -it --rm -v `pwd`:/project  jakzal/phpqa:alpine phpstan --version
PHPStan - PHP Static Analysis Tool 0.8.4.0
[dado@fredo rollerworks-search]$ docker run -it --rm -v `pwd`:/project -w /project jakzal/phpqa:alpine phpstan --version

Fatal error: Uncaught Error: Class 'PHPStanVendor\Jean85\PrettyVersions' not found in phar:///usr/local/bin/phpstan/bin/phpstan:23
Stack trace:
#0 /usr/local/bin/phpstan(4): require()
#1 {main}
  thrown in phar:///usr/local/bin/phpstan/bin/phpstan on line 23

Edit: I'm guessing PHAR is picking up my own vendor/ folder for some reason? If I delete it, it runs fine.

Steps to reproduce:

phpstan.neon contains:

parameters:
    autoload_files:
        - vendor/autoload.php
    excludes_analyse:
        - vendor/

in root of your project, containing your own vendor/, run

docker run -it --rm -v `pwd`:/project -w /project jakzal/phpqa:alpine phpstan analyse --configuration phpstan.neon --level max .

Should get the same error.

dkarlovi on 4 Nov 2017

Oh, I had phpstan installed in my vendor/ too (migrating to a Docker-based solution). Once removed, it works as expected.

In any way, phar shouldn't really care about any of that, it should work regardless.

dkarlovi on 4 Nov 2017

It seems that, for some strange reason, the PHAR cares about the local/global autoloader: https://github.com/Ocramius/PackageVersions/issues/48#issuecomment-338867092

Jean85 on 6 Nov 2017

@Jean85 Do you have a suggestion how to prevent this error in case both are installed?

ondrejmirtes on 6 Nov 2017

Maybe generating a random namespace prefix in the PHAR? It's a hack, but since it's hard to pin down why this clash occurs...

Jean85 on 6 Nov 2017

I must admit that I do not understand the nature of the problem. The problem is Fatal error: Uncaught Error: Class 'PHPStanVendor\Jean85\PrettyVersions' not found. And the class exists in two versions when this occurs:

PHPStanVendorJean85\PrettyVersions from the PHAR
Jean85\PrettyVersions installed via composer locally/globally

So I don't get why does it result in this error.

ondrejmirtes on 6 Nov 2017

Question is, why is PHAR allowing its autoloader to get overriden? Shouldn't it all be baked in by default?

dkarlovi on 7 Nov 2017

PHPStan needs to autoload classes from the analyzed project.

ondrejmirtes on 7 Nov 2017

So, is this error coming from the autoloader loading PHPStan itself or PHPStan's autoloader? It seems like the former, still feels like that autoloader should be untouched by the project's autoloader.

Basically, PHPStan should use own autoloader for itself always, they shouldn't come into contact.

dkarlovi on 7 Nov 2017

Umh.... maybe the autoloaders are not chained correctly and the local one overrides the one inside the PHAR?

Jean85 on 7 Nov 2017

That's exactly what I'm thinking. So, autoloader loading PHPStan (ALPS) should be classmap-based, and the class map is built when the PHAR is built. After that, PHPStan's autoloader (PSA) which is probably just loading the project's autoload.php would kick in.

This way, the autoload process would go

ALPS
PSA
project's autoloader

If PHAR is trying to load itself, it would always succeed in 1) and it should never reach beyond that. Everything else is loaded from 2) forward (ALPS always misses). It probably works like this already, but something is off by one somewhere. I'm guessing so because PSA is error-managed by PHPStan already, ALPS isn't.

dkarlovi on 7 Nov 2017

ping

dinamic on 17 May 2018

@dinamic Why are you pinging? This is not a solved issue, if you have a solution, I'm open for it.

The problem is that globally and locally installed PHPStan instances clash. So if you see this error it means that you're either:

1) Running a locally installed PHPStan (meaning in a project) while there's one installed globally (using composer require -g.
2) Running a globally installed PHPStan (using composer require -g) while there's one installed localy in a project.

ondrejmirtes on 17 May 2018

Steps to reproduce in my instance:

use docker to run phpstan
composer require phpstan/phpstan-phpunit --dev into the project
try to invoke it

Requiring phpstan/phpstan-phpunit would require also phpstan/phpstan, which seems to be causing the problem here.

Maybe phpstan/phpstan-phpunit can suggest phpstan/phpstan, but not require it?

dinamic on 17 May 2018

@ondrejmirtes, just suggested a solution. Maybe we were typing at the same time.

dinamic on 17 May 2018

@dinamic You have a completely different problem and this error is just a side effect. When using PHPStan with its extensions, they have to see each other. So when using the docker image, you have to install PHPStan extensions alongside PHPStan. See "Install PHPStan extensions" at https://github.com/phpstan/docker-image/blob/master/README.md

ondrejmirtes on 17 May 2018

👍1

I'm using jakzal's phpqa docker image, so I will request the extension to be installed there.

Thanks for the solution, @ondrejmirtes! Much appreciated!

dinamic on 17 May 2018

Phpstan: Jean85\PrettyVersions not found

All 38 comments

0 /usr/local/bin/phpstan.phar(4): require()

1 {main}

>

Composer

Phar

Composer

Phar

Related issues