Phpstan: for cycle: third argument scope places before continue or the end of cycle

Created on 28 Mar 2017  路  3Comments  路  Source: phpstan/phpstan

image

image

$parent must be always defined as $parent = $this->parent(...); is executed before any continue; or the end of cycle.

php-ds/polyfill source

bug
Source
picture jkuchar

Most helpful comment

Nice catch, fix is easy. I already touched for loop code for the 0.9 release here https://github.com/phpstan/phpstan/commit/c848ed2728bd0bcb96c4c41d4c169118dec40ab4 so I will modify it once more.

picture ondrejmirtes on 30 Aug 2017
❤1 👍1

All 3 comments

Isolated as https://phpstan.org/r/59a352bf7510b7997c687c1ced291cac

JanTvrdik picture JanTvrdik on 30 Aug 2017

Nice catch, fix is easy. I already touched for loop code for the 0.9 release here https://github.com/phpstan/phpstan/commit/c848ed2728bd0bcb96c4c41d4c169118dec40ab4 so I will modify it once more.

ondrejmirtes picture ondrejmirtes on 30 Aug 2017
❤1 👍1

Fixed as part of: https://github.com/phpstan/phpstan/commit/e9391009adc930b7b4b0570167c057fdc97cabbe

ondrejmirtes picture ondrejmirtes on 19 Nov 2017
Was this page helpful?
0 / 5 - 0 ratings

Related issues

hrach picture hrach  路  3Comments
hrach picture hrach  路  3Comments
mitelg picture mitelg  路  3Comments
odan picture odan  路  3Comments
mfn picture mfn  路  3Comments