Phpstan: migrate coding style to psr-1 and psr-2

Created on 10 Mar 2017 · 4Comments · Source: phpstan/phpstan

do you want to use 4 space instead of tab ?

Source

lvht

👍2 👎1

All 4 comments

No, I'm happy with the coding standard as it is. I'm using many sniffs from Slevomat CS: https://github.com/slevomat/coding-standard

ondrejmirtes on 10 Mar 2017

More and more framework has been migrated to psr-1 and psr-2 coding style. The whole community are migrating to this coding style as well. Maybe you are happy with some other coding style.

But once you make you phpstan opensource, phpstan is not you personal project any more. As a project leader, it is your duty to make phpstan more easily to be contributed by the whole community. When people deal with most other php sources, they use ps4 coding style; when they deal with yours, they have to the style you like. I do not see any benefit for your personal coding style choice.

Maybe you need to reconsider this issue seriously, for the community.

lvht on 10 Mar 2017

👎2 😕1 👍1

This is bikeshedding - focusing on the unimportant stuff instead of making
the tool useful.

Not having psr1 or 2 does not mean that no one can contribute. On the
contrary in fact - more and more people are contributing and I don't see
any hurdles for them.

On Fri, 10 Mar 2017 at 08:01, 吕海涛 notifications@github.com wrote:

More and more framework has been migrated to psr-1 and psr-2 coding style.
The whole community are migrating to this coding style as well. Maybe you
are happy with some other coding style.

But once you make you phpstan opensource, phpstan is not you personal
project any more. As a project leader, it is your duty to make phpstan more
easily to be contributed by the whole community. When people deal with most
other php sources, they use ps4 coding style; when they deal with yours,
they have to the style you like. I do not see any benefit for your personal
coding style choice.

Maybe you need to reconsider this issue seriously, for the community.

—
You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub
https://github.com/phpstan/phpstan/issues/181#issuecomment-285593863,
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAGZuMwzZT-W2RFLJxYoIv540YdSOcXSks5rkPVegaJpZM4MZBJV
.

>