Phpspreadsheet: PHP 7.1 compatibility
There are currently 5 failing tests that prevent us to declare PHP 7.1 compatibility. Any help to solve those would be very much appreciated.
PowerKiKi
All 4 comments
I see no one is assigned yet, I would like to jump on it, and see if I can help.
ankitm123
on 21 Feb 2017
Any help with this is welcome, thank you for offering your help. You could submit separate PR for each tests or all at once, up to you.
PowerKiKi
on 22 Feb 2017
3 issues were fixed, but the remaining 2 issues are due to the dompdf package. I changed composer.json file to require 0.8.0v for Dompdf, it still gives the same issue. I will look into it a bit more.
Check this link: https://github.com/dompdf/dompdf/releases/tag/v0.8.0
ankitm123
on 24 Feb 2017
Updating to v0.8.0 for dompdf does fix the remaining issues. Take a look at the passing tests for php 7.1.Now that the build completed for php 7.1, Do we need to keep php 7.1 in the allowed failure list? Guess not.
ankitm123
on 24 Feb 2017
Related issues
alexbog8
路
4Comments
jcroucher
路
4Comments
ariefbayu
路
3Comments
PowerKiKi
路
5Comments
smartlara
路
5Comments
Most helpful comment
Updating to v0.8.0 for dompdf does fix the remaining issues. Take a look at the passing tests for php 7.1.Now that the build completed for php 7.1, Do we need to keep php 7.1 in the allowed failure list? Guess not.