Phpredis: Migrating to PHPUnit

[marius-meissner]

At the current state of the art, are there any major drawbacks to not use PHPUnit?

The current "test framework" implementation fullfills the needs quite ok, but using PHPUnit could give use in my eyes a few advantages:

• Les maintainability of the custom Test suite implementation
• More precise assertions (Not equals, Count more/less) including more detailed debugging messages
• More flexible test suite configuration
• Test grouping
• Central setup and tear down management
• In general better clarity and standardization
• ...

What do you think?

[remicollet]

Common usage for PHP extension is to use the phpt format.

Especially when bootstrapping the PHP stack (full rebuild) the will make dependency / build order more complex, as usually the arched packages (binary extensions) are build before noarch ones (pure-PHP libraries / applications), and some people even prefer to build all extensions in the php tree.

So -1 to depend on PHPUnit.

[yatsukhnenko]

IMO phpt format looks a bit strange/unfamiliarly but since it is a standart for php extensions I agree with @remicollet
@michael-grunder any thoughts?

[michael-grunder]

I've never used phpt but am not opposed to the idea in principle.

We have a very large test suite so it will be no small task. I'll read up on phpt first. Perhaps some of the test migration could even be automated.

[yatsukhnenko]

There is no needness migrating to any other framework right now :smile:

[yatsukhnenko]

Maybe later. :smile: