Phpmyadmin: Replication actions do not work for primary replica on primary replica

[rolfjentsch]

I had some servers that used to replicate the fiine. I had to cut the repliication for a year or so.
I did an update to phpadmin 4.9.0.1 and tryed to reinitialise replication

getting the following result

Warning in ./libraries/classes/DatabaseInterface.php#311
Illegal offset type in isset or empty

Backtrace

./libraries/classes/DatabaseInterface.php#1782: PhpMyAdmin\DatabaseInterface->tryQuery(
string 'SHOW MASTER STATUS',
,
integer 0,
boolean false,
)
./libraries/classes/Replication.php#164: PhpMyAdmin\DatabaseInterface->fetchResult(
string 'SHOW MASTER STATUS',
NULL,
NULL,
,
)
./libraries/classes/ReplicationGui.php#997: PhpMyAdmin\Replication::slaveBinLogMaster()
./libraries/classes/ReplicationGui.php#916: PhpMyAdmin\ReplicationGui::handleRequestForSlaveChangeMaster()
./server_replication.php#52: PhpMyAdmin\ReplicationGui::handleControlRequest()

i retried it with an other Database and an other nas ..... same error

hwat shall i do .. ist it a bug ?
if so the next edition will adress it ?

[williamdes]

Param | Value
-----------|--------------------
Error Type | Warning
Error Message |Illegal offset type in isset or empty
Exception Type |php
phpMyAdmin version |4.9.0.1
Incident count | 4
Link | Report#58426

This comment is posted automatically by phpMyAdmin's error-reporting-server.

[williamdes]

@rolfjentsch Thanks for reporting, other users seem to have the same error.
We will have a look ASAP

[rolfjentsch]

any Progress on this ?

[p-rakowski89]

Hello.
I tested different phpmyadmin versions today because of the inability to run replication. The last version with the option working is phpmyAdmin-4.7.8 in newer versions the modules do not work correctly. When will you improve?

[williamdes]

I am trying to reproduce this issue but for now I did not succeed

[williamdes]

@rolfjentsch @p-rakowski89 I would be very happy to include a fix in the next version if someone can send screenshots and more instructions to reproduce the issue (step by step ?)

[williamdes]

:ping_pong:

[p-rakowski89]

Hi, I have problems with replication management, just like trying to stop,
start threads, etc. Here is ss.
Version phpmyadmi 4.9.2
greetings

[p-rakowski89]

[williamdes]

@p-rakowski89 56e8ebd8e99609b59e6a77363702caa3ff0b1b8b #15641
for the last screenshot

[p-rakowski89]

Ok, replication now starts normally. But skipping errors doesn't work well.
My guess is that this note is also missing.
But I report to help correct errors.

[williamdes]

@rolfjentsch Can you help reproduce the issue so I can fix it ?

[p-rakowski89]

it seems to me that this is the solution to the problem

    public static function handleRequestForSlaveSkipError()
    {
        $count = 1;
        if (isset($_POST['sr_skip_errors_count'])) {
            $count = $_POST['sr_skip_errors_count'] * 1;
        }

<      $qStop = Replication::slaveControl("STOP");
>      $qStop = Replication::slaveControl("STOP", null, DatabaseInterface::CONNECT_USER);
        $qSkip = $GLOBALS['dbi']->tryQuery(
            "SET GLOBAL SQL_SLAVE_SKIP_COUNTER = " . $count . ";"
        );
<      $qStart = Replication::slaveControl("START");
>      $qStart = Replication::slaveControl("START", null, DatabaseInterface::CONNECT_USER);

        $result = ($qStop !== false && $qStop !== -1 &&
            $qSkip !== false && $qSkip !== -1 &&
            $qStart !== false && $qStart !== -1);

        return $result;
    }

[williamdes]

774fc686bb1e874cae5a73e0960fd81abe605fea

[kartik1000]

@williamdes Hey why is this issue still opened? Has the last commit not fixed it?

[williamdes]

@rolfjentsch Is this issue fixed ?

hey @kartik1000 I do not know :)

[kartik1000]

@rolfjentsch If you can let us know how you reproduced it maybe, we can check. Else you can check and let us know :)

[rolfjentsch]

Hi,
Even with Version 4.9.4 i Keep getting this error
Mit freundlichen Grüßen
Rolf Jentsch

[williamdes]

Hi @rolfjentsch can you send the error, It seems that you tried to include it in the email but it got removed

[rolfjentsch]

Here u go again
Mit freundlichen Grüßen
Rolf Jentsch

[rolfjentsch]

and one more try as an attachment
Mit freundlichen Grüßen
Rolf Jentsch

[williamdes]

@rolfjentsch Sorry but you can not use attachements you need to go to https://github.com/phpmyadmin/phpmyadmin/issues/15367 and post the screenshots or use an external service and post the link here

[rolfjentsch]

Well it seems to be the same as posted on #15367
Mit freundlichen Grüßen
Rolf Jentsch

[williamdes]

Hi @rolfjentsch
Can you try version 5.0 of phpMyAdmin?
Also please post the new stack trace, it is very important for us to debug :)

[p-rakowski89]

Hi,
I keep watching this conversation about replication. I am sorry to say that no replication options work for phpmyadmin> 5.
I checked them all. It is strange that phpmyadmin does not report any error. As it was in version 4.9.1.
If necessary, I can test the changes. I have 5 master servers and 10 slaves.

[williamdes]

@p-rakowski89 If you can try the download the latest version in development (phpMyAdmin 5.0+snapshot) and let me know what I should do
Because I tried after making a fix and everything was okay

[p-rakowski89]

I downloaded
1 - phpMyAdmin 5.1+snapshot Daily snapshot, generated 2020-02-19, from Git commit 922cd6bd69c1fff5cdbfe39faa50927454fa4ff3.Future version compatible with PHP 7.1 and newer and MySQL 5.5 and newer.
2- phpMyAdmin 5.0+snapshot Daily snapshot, generated 2020-02-19, from Git commit a4fcf79db08b38a3de8f4e06c59ebfb1665528fd.Current version compatible with PHP 7.1 and newer and MySQL 5.5 and newer.

They behave the same from my observations. No error whatsoever. The FULL STOP task does not work like any other.
I have installed:

[williamdes]

Thank you, I will have a look once more

[rolfjentsch]

Hi William,
I downloaded and installed 5.01

When trying to “change Masterserver or configure it new” nothing happens.

Pphpadmin reports “loading” for a short time but no new window opens

So unfortunately I cant Test it

Mit freundlichen Grüßen

Rolf Jentsch

[rolfjentsch]

I also downloaded https://files.phpmyadmin.net/snapshots/phpMyAdmin-5.1+snapshot-all-languages.zip phpMyAdmin-5.1+snapshot-all-languages.zip and tried it

Same result

Thin menu point Master-Server wechseln oder neu konfigurieren http://qnap/phpMyAdmin5/index.php?route=/server/replication leads nowhere

Mit freundlichen Grüßen
Rolf Jentsch

[rolfjentsch]

Also downloaded this Versionsinformationen: 5.0.2-dev, aktuelle stabile Version: https://www.phpmyadmin.net/files/5.0.1/ 5.0.1

Clicked on replication and then http://qnap/phpMyAdmin5/server_replication.php Master-Server wechseln oder neu konfigurieren

Dsmr Rresult – nothing happened

Tried a different browser (this time chrome) but same results

Mit freundlichen Grüßen
Rolf Jentsch

[p-rakowski89]

Hi,
And how are you solving this problem?
Will it be touched?

[williamdes]

Hi
I have quite a lot issues to manage and appreciate that you asked for some news on this one :)
Assigned to the next milestone to try to fix this one as soon as possible.

[williamdes]

@p-rakowski89 Could you please try 5.0 ?
I do not understand where is the issue and could not reproduce it ..

[p-rakowski89]

Hi, So far while testing v5 and above, I have failed to stop, start or
reset a slave from the replication menu. As if the button didn't work. If
you need a more detailed description, I can record a video of this problem

[williamdes]

Hi, So far while testing v5 and above, I have failed to stop, start or reset a slave from the replication menu. As if the button didn't work. If you need a more detailed description, I can record a video of this problem

Hi,

Could you please record a video, that would be helpful :)

[p-rakowski89]

Hi,
I recorded as you asked. The first video is on phpmyadmin 5.0.2 - where it
doesn't work. Link to the movie - https://user-images.githubusercontent.com/7784660/102380027-bdc86200-3fc7-11eb-96d7-562f7a4e25b4.gif

Second video of phpmyadmin 4.9.5 where it works. Link to the movie - https://user-images.githubusercontent.com/7784660/102380036-c15be900-3fc7-11eb-8073-7543af1b028d.gif

How would you have a problem with playing movies, just download.

[williamdes]

Hi @p-rakowski89
Please try out 1f9ef1ffb96abd2146873e087a59706e76007283 I think this will fix all the issues you show in your video
Let me know :)

[p-rakowski89]

Works well. Thanks