Phpinspectionsea: Wrong inspection behavior

[xepozz]

Local variable is needed, but inspection says it isn't

[WinterSilence]

@xepozz assign $response at return?

[xepozz]

$response is used in finally statement

[WinterSilence]

@xepozz you cant use return $response = ...

[orklah]

@xepozz you cant use return $response = ...

You definitely can:
https://3v4l.org/PiOFX

I'm not sure if you should, but there's no technical issue

[WinterSilence]

@orklah technically possible, but this is bad practice:

result will be returned after the finally block is executed

if $response is object, then it's can be changed in "finally" block

[xepozz]

I can move the return statement out of try/catch block, but this is a short form looks and works nice, I don't want to do this.

[kalessil]

Hm, that pretty awesome use of finally =) I made a fix to support this case.

[xepozz]

Thanks!